Remove missing-references ctest#12434
Merged
Merged
Conversation
Checking missing references has been implemented as /static-checks/rule-identifiers Contest test and is part of /static-checks CI check.
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit d8dc1d3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.5% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checking missing references has been implemented as
/static-checks/rule-identifiersContest test and is part of/static-checksCI check.Rationale:
missing-referencesctest was unnecessary complicated as it was Bash script callingbuild-scripts/profile_tool.py statswhich is not intended as test but as a tool for obtaining various profile statistics.Newly introduced test in Contest RHSecurityCompliance/contest#265 is easily extensible for new references, waive-able (via Contest waivers), and simpler.
Review Hints:
See CI checks that
missing-referencesis not part of ctests and that/static-checks/rule-identifiersdoes what's expected (see link above and run in Testing Farm CentOS static-checks).