Skip to content

Implement new rule firewall_single_service_active#12822

Merged
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_4.1.1
Jan 16, 2025
Merged

Implement new rule firewall_single_service_active#12822
dodys merged 2 commits into
ComplianceAsCode:masterfrom
mpurg:ubuntu2404_cis_4.1.1

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Jan 14, 2025

Description:

  • Implemented new rule for checking that only one firewall service is active. No remediation is provided since that is handled by other rules (service_ufw_enabled, ...)
  • Added rule to Ubuntu 24.04 CIS controls

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 4.1.1

@mpurg mpurg requested a review from a team as a code owner January 14, 2025 10:01
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 14, 2025

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 14, 2025
@github-actions
Copy link
Copy Markdown

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Jan 14, 2025
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 14, 2025
@dodys dodys added this to the 0.1.76 milestone Jan 14, 2025
mpurg added 2 commits January 15, 2025 11:52
New rule for checking that only one firewall service is active.
Satisfies Ubuntu 24.04 CIS control 4.1.1
@mpurg mpurg force-pushed the ubuntu2404_cis_4.1.1 branch from a3aa2af to 66f4ca7 Compare January 15, 2025 10:52
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 66f4ca7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.8% (0.0% change).

View more on Code Climate.

Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 49d91d8 into ComplianceAsCode:master Jan 16, 2025
@@ -0,0 +1,10 @@
#!?bin/bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/" instead of "?" for all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants