Skip to content

Alma9 more changes (mk2)#12905

Merged
Mab879 merged 6 commits into
ComplianceAsCode:masterfrom
sej7278:alma9-more-changes
Feb 3, 2025
Merged

Alma9 more changes (mk2)#12905
Mab879 merged 6 commits into
ComplianceAsCode:masterfrom
sej7278:alma9-more-changes

Conversation

@sej7278
Copy link
Copy Markdown
Contributor

@sej7278 sej7278 commented Jan 27, 2025

Replaces #12883 which got closed accidentally.

Rebased against master (resolved 2 conflicts).

@sej7278 sej7278 requested review from a team as code owners January 27, 2025 13:52
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 27, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 27, 2025

Hi @sej7278. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mab879 Mab879 added this to the 0.1.76 milestone Jan 27, 2025
@Mab879 Mab879 self-assigned this Jan 27, 2025
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Jan 27, 2025
Copy link
Copy Markdown
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is merge conflict now. Hopefully we can get the approvals soon.

cc for review
@ComplianceAsCode/suse-maintainers
@ComplianceAsCode/oracle-maintainers

@sej7278
Copy link
Copy Markdown
Contributor Author

sej7278 commented Jan 29, 2025

Lol, I'll rebase in the morning, problem is other stuff is getting merged quicker than this 🤣

@sej7278 sej7278 force-pushed the alma9-more-changes branch from 5849e08 to dd7e95e Compare January 30, 2025 18:31
@sej7278
Copy link
Copy Markdown
Contributor Author

sej7278 commented Jan 30, 2025

ok, rebased again, seems like its just the platform = .... multi_platform_almalinux line that is conflicting as people update the scripts for suse/ubuntu

@sej7278 sej7278 force-pushed the alma9-more-changes branch from dd7e95e to fd3cc71 Compare February 1, 2025 12:37
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit fd3cc71 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Copy Markdown
Member

Mab879 commented Feb 3, 2025

Overriding CODEOWNERS since it is just excluding a rule from SUSE.

@Mab879 Mab879 merged commit 10568b6 into ComplianceAsCode:master Feb 3, 2025
@sej7278 sej7278 deleted the alma9-more-changes branch February 4, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants