Skip to content

Use platform specific audit binaries#13786

Merged
vojtapolasek merged 6 commits into
ComplianceAsCode:masterfrom
teacup-on-rockingchair:audit_binaries_file_perm
Sep 2, 2025
Merged

Use platform specific audit binaries#13786
vojtapolasek merged 6 commits into
ComplianceAsCode:masterfrom
teacup-on-rockingchair:audit_binaries_file_perm

Conversation

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor

Description:

  • Use platform specific audit binaries path definitions

Rationale:

  • Define platform specifc paths for audit binaries

  • The oval checks in file_permissions_auditd rule so oval checks pass for sle15 platform. Instead of using symlinks to those binaries because oval checks fail when using symlinks

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 12, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.78 milestone Aug 16, 2025
@teacup-on-rockingchair teacup-on-rockingchair added SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. labels Aug 16, 2025
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review August 16, 2025 06:36
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 16, 2025
- /sbin/ausearch
{{% if product not in ["rhel10"] %}}- /sbin/autrace{{% endif %}}
- /sbin/auditd
{{% if 'rhel' not in product %}}- /sbin/audispd{{% endif %}}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe audispd should be excluded on Ubuntu also, see #13715
fyi @alanmcanonical

Copy link
Copy Markdown
Contributor

@Xeicker Xeicker Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audispd should also be excluded from OL, We usually use the codition "ol" in families, to condition OL content

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the feedback should be handled in 19ba63e

@vojtapolasek vojtapolasek self-assigned this Aug 21, 2025
@vojtapolasek
Copy link
Copy Markdown
Collaborator

@teacup-on-rockingchair do you plan to continue on this PR? From RHEL point of view, it does not bring any changes. You just need to update data for product stability tests.

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor Author

@teacup-on-rockingchair do you plan to continue on this PR? From RHEL point of view, it does not bring any changes. You just need to update data for product stability tests.

Thanks 🙇 product stability updates should be handled at c8cb7d2

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@teacup-on-rockingchair can you please rebase to the latest master? I still can see some product stability test failures, the rebase will ensure that they are not caused by you PR. Thank you.

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor Author

@teacup-on-rockingchair can you please rebase to the latest master? I still can see some product stability test failures, the rebase will ensure that they are not caused by you PR. Thank you.

done 👍

@Mab879 Mab879 removed this from the 0.1.78 milestone Aug 25, 2025
@Mab879 Mab879 added this to the 0.1.79 milestone Aug 25, 2025
@vojtapolasek
Copy link
Copy Markdown
Collaborator

/packit retest-failed

@vojtapolasek
Copy link
Copy Markdown
Collaborator

Hello @teacup-on-rockingchair thank you for the rebase.
I think you still need to update some data files for product stability tests.
Here is how you can test it locally.

  1. ./build_product
  2. cd build
  3. ctest -R '.stable.'
  4. read the results in Testing/Temporary/LastTest.log
    Thank you.

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor Author

Hello @teacup-on-rockingchair thank you for the rebase. I think you still need to update some data files for product stability tests. Here is how you can test it locally.

  1. ./build_product
  2. cd build
  3. ctest -R '.stable.'
  4. read the results in Testing/Temporary/LastTest.log
    Thank you.
    Hi @vojtapolasek , unfortunately I cannot reproduce any issue with stability tests or any other. Attaching the capture of my results, please can you advise on which test do you exactly see the issue?
    log_cac.log

Copy link
Copy Markdown
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I am sorry for the inconvenience, failing test results were caused by some additional untracked files in my copy of the git repo.
From RH side, this PR is OK.

@vojtapolasek
Copy link
Copy Markdown
Collaborator

@ComplianceAsCode/ubuntu-maintainers @ComplianceAsCode/suse-maintainers please check changes and we can merge this.

Copy link
Copy Markdown
Contributor

@alanmcanonical alanmcanonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@teacup-on-rockingchair
Copy link
Copy Markdown
Contributor Author

@ComplianceAsCode/ubuntu-maintainers @ComplianceAsCode/suse-maintainers please check changes and we can merge this.

@vojtapolasek I am the only member of this group so cannot approve my own PR :)

Copy link
Copy Markdown
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys
Copy link
Copy Markdown
Contributor

dodys commented Sep 2, 2025

@Mab879 @vojtapolasek could you override the codeowner for suse? since the only person that can approve is also the author of the PR

@vojtapolasek vojtapolasek merged commit 7fa1da0 into ComplianceAsCode:master Sep 2, 2025
130 of 131 checks passed
@vojtapolasek
Copy link
Copy Markdown
Collaborator

Merged. I am sorry that it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants