Use platform specific audit binaries#13786
Conversation
|
Skipping CI for Draft Pull Request. |
| - /sbin/ausearch | ||
| {{% if product not in ["rhel10"] %}}- /sbin/autrace{{% endif %}} | ||
| - /sbin/auditd | ||
| {{% if 'rhel' not in product %}}- /sbin/audispd{{% endif %}} |
There was a problem hiding this comment.
I believe audispd should be excluded on Ubuntu also, see #13715
fyi @alanmcanonical
There was a problem hiding this comment.
audispd should also be excluded from OL, We usually use the codition "ol" in families, to condition OL content
There was a problem hiding this comment.
👍 thanks for the feedback should be handled in 19ba63e
|
@teacup-on-rockingchair do you plan to continue on this PR? From RHEL point of view, it does not bring any changes. You just need to update data for product stability tests. |
Thanks 🙇 product stability updates should be handled at c8cb7d2 |
|
@teacup-on-rockingchair can you please rebase to the latest master? I still can see some product stability test failures, the rebase will ensure that they are not caused by you PR. Thank you. |
The oval checks in file_permissions_auditd rule so oval checks pass for sle15 platform Instead of using symlinks to those binaries because oval checks fail when using symlinks
c8cb7d2 to
e255cc0
Compare
done 👍 |
|
/packit retest-failed |
|
Hello @teacup-on-rockingchair thank you for the rebase.
|
|
vojtapolasek
left a comment
There was a problem hiding this comment.
Looks good now. I am sorry for the inconvenience, failing test results were caused by some additional untracked files in my copy of the git repo.
From RH side, this PR is OK.
|
@ComplianceAsCode/ubuntu-maintainers @ComplianceAsCode/suse-maintainers please check changes and we can merge this. |
@vojtapolasek I am the only member of this group so cannot approve my own PR :) |
|
@Mab879 @vojtapolasek could you override the codeowner for suse? since the only person that can approve is also the author of the PR |
7fa1da0
into
ComplianceAsCode:master
|
Merged. I am sorry that it took so long. |
Description:
Rationale:
Define platform specifc paths for audit binaries
The oval checks in file_permissions_auditd rule so oval checks pass for sle15 platform. Instead of using symlinks to those binaries because oval checks fail when using symlinks