Remove deprecated CIS OpenShift 1.4.0 and 1.5.0 profiles#13832
Merged
Conversation
Collaborator
rhmdnd
commented
Aug 28, 2025
rhmdnd
commented
- CMP-3713: Remove CIS OpenShift 1.4.0 Profiles
- CMP-3714: Remove CIS OpenShift 1.5.0 Profiles
- Rename cis_ocp_1_4_0 to cis_ocp_1_7_0
rhmdnd
changed the title
These were deprecated last release, and we're removing them in favor of the newer profile (1.7.0).
These were deprecated last release, and we're removing them in favor of the newer profile (1.7.0).
Since we're removing the old profile, let's also change the control organization so that it doesn't reference an old profile.
Collaborator
Author
|
@Mab879 Do you know if there is a way to exclude yamllint checks on profiles we're removing? CI linter is failing because it can't lint a file we've removed. |
Member
|
The way the check works is rather naive, something we can improve later. In the meantime, since it isn't a required check we can just merge as is. |
Collaborator
|
cis 1.40 and cis 1.5.0 have been removed |
yuumasato
reviewed
Aug 29, 2025
Member
yuumasato
left a comment
yuumasato
left a comment
There was a problem hiding this comment.
Looks great.
I just have a small nit pick.
We can make maintaining this profile a little easier on ourselves by removing the version from the name. The version is already encapsulated as part of the profile data.
yuumasato
approved these changes
Sep 1, 2025
jan-cerny
added
the
Highlight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.