Skip to content

Backport of PR #12569#18

Merged
PoisonPhang merged 3 commits into
polkadot-v0.9.27from
connor/fungibles-backport
Nov 10, 2022
Merged

Backport of PR #12569#18
PoisonPhang merged 3 commits into
polkadot-v0.9.27from
connor/fungibles-backport

Conversation

@PoisonPhang
Copy link
Copy Markdown

@PoisonPhang PoisonPhang commented Nov 9, 2022

https://app.clickup.com/t/358r3ft

Backport of PR #12569

Auto format did indeed auto-format

Copy link
Copy Markdown

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread frame/balances/src/tests.rs
@PoisonPhang
Copy link
Copy Markdown
Author

I can build this branch fine, but running cargo test --all produces this result

error[E0437]: type `Event` is not a member of trait `pallet_asset_tx_payment::Config`
   --> frame/transaction-payment/asset-tx-payment/src/tests.rs:201:2
    |
201 |     type Event = Event;
    |     ^^^^^^^^^^^^^^^^^^^ not a member of trait `pallet_asset_tx_payment::Config`

For more information about this error, try `rustc --explain E0437`.

Can anyone else confirm this behavior?

@dzmitry-lahoda
Copy link
Copy Markdown

imho read the nix. do what nix does. nixify your local scripts and share with us. ci = local.

@PoisonPhang
Copy link
Copy Markdown
Author

PoisonPhang commented Nov 10, 2022

All tests pass with cargo nextest run --workflow, however, the same is not true with cargo test --all. This issue exists within the ComposableFi/substrate/polkadot-v0.9.27 branch as well. This is not present on paritytech/substrate from what me and @benluelo can tell.

After fixing the Event config, a new error (that happens as described above) happens for test_tracing

Context: Parity uses cargo nextest in their CI

imho read the nix. do what nix does. nixify your local scripts and share with us. ci = local.

I need to re-partition my root directory before I can correctly run nix commands.

@PoisonPhang PoisonPhang merged commit 9bdc51a into polkadot-v0.9.27 Nov 10, 2022
@PoisonPhang PoisonPhang deleted the connor/fungibles-backport branch November 10, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants