This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(workflows): pass GITHUB_TOKEN to build, allow schedule + dispatch#46
Merged
Merged
Conversation
Two related tweaks to the centralized documentation deploy: - Build step now sees GITHUB_TOKEN. Lets npm prebuild scripts hit the GitHub API authenticated. Conduction-website is about to use this for nightly app-downloads enumeration (331 ConductionNL repos); unauthenticated would hit the 60 req/hr ceiling on every build. - Drop the 'push only' guard so scheduled and dispatched runs also deploy. Currently workflow_dispatch is a no-op on every product repo, which is confusing. Lets conduction-website add a nightly cron that triggers a fresh build with refreshed data without a bot push to a protected branch.
rubenvdlinde
added a commit
to ConductionNL/conduction-website
that referenced
this pull request
May 8, 2026
…low (#26) The old .github/workflows/app-downloads.yml ran nightly and tried to git push the regenerated data/app-downloads.json to development. The org-wide PR-required ruleset blocked the bot push, so the data went stale and the homepage showed '0 downloads'. Move the refresh to a Docusaurus prebuild step so the JSON is regenerated on every site build. No bot push, no rule fight. Add a nightly cron + workflow_dispatch trigger to documentation.yml so the site rebuilds daily even without code changes, refreshing the data each time. Centralized workflow already (PR ConductionNL/.github#46) passes GITHUB_TOKEN to the build step so the script can authenticate against the GitHub API and avoid the 60 req/hr unauth ceiling on the 331-repo enumeration. The committed JSON snapshot stays for local-dev convenience but is overwritten on every CI build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related tweaks to the centralized documentation deploy reusable workflow:
GITHUB_TOKEN. Lets npm prebuild scripts hit the GitHub API authenticated. Conduction-website is about to use this for nightly app-downloads enumeration (331 ConductionNL repos); unauthenticated would hit the 60 req/hr ceiling on every build. Token is auto-scoped to the run.scheduleandworkflow_dispatchalso deploy. Currentlyworkflow_dispatchis a no-op on every product repo, which is confusing. Lets conduction-website add a nightly cron that triggers a fresh build with refreshed data, without a bot push to a protected branch.Used by every product subdomain (
mydash,opencatalogi,docs.conduction.nl, etc.) so the changes apply org-wide. PR runs still build but don't deploy (thepull_requestevent isn't in the newif:list).