This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: annotate 70 backend methods to zero spec-coverage gaps#68
Merged
Merged
Conversation
Maps all 70 uncovered Controller/Service/Listener methods to the four existing capability specs (version-management, external-sources, pat-management, app-discovery) via @SPEC docblock tags. No new REQs were needed — the specs already describe every method's behaviour. Drives gate-16 spec-coverage to 0 uncovered backend methods.
rubenvdlinde
added
openspec
Contributor
Quality Report — ConductionNL/app-versions @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 282/282 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 20:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Spec Coverage Annotation
Drives gate-16 spec-coverage for app-versions from 70 uncovered backend methods → 0.
What this PR does
@spec openspec/specs/<capability>/spec.mddocblock tags to all 70 in-scope Controller / Service / Listener methods.version-management— installed-apps list, version fetch, install (signed path), finalizer, page shellexternal-sources— source abstraction/registry/binding, trusted-source allowlist, GitHub release source, external installerpat-management— PAT storage/validation/encryption, resolver, deeplink, user-deletion sweepapp-discovery— provider interface, App Store / GitHub-private / GitHub-search providers, aggregatorWhat this PR does NOT do
@spec excludemarkers — every worklist method is a true capability covered by an existing REQ.Verification
csc.py --mode report->uncovered_count: 0php -lclean on all 26 changed filesSource: gate-16 spec-coverage report (app-versions worklist, 2026-05-25).