Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

Replace 'Case studies' footer link with 'Way of Work'#27

Merged
rubenvdlinde merged 2 commits into
developmentfrom
feature/footer-way-of-work
May 25, 2026
Merged

Replace 'Case studies' footer link with 'Way of Work'#27
rubenvdlinde merged 2 commits into
developmentfrom
feature/footer-way-of-work

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Collaborator

Summary

  • Footer's Case studies entry pointed at the academy filter /academy?type=case-study, which is content-led, not company-led. Replaces it with Way of Work, pointing at https://docs.conduction.nl/WayOfWork/way-of-work/ — the canonical "how Conduction operates day-to-day" landing, recently rebuilt on the docs site.
  • Adds the matching NL i18n entry: Werkwijze.

Test plan

  • Build runs cleanly (npm run build).
  • EN footer Conduction column reads: About / Open source / Team / Way of Work / ISO / Identity.
  • NL footer Conduction column reads: Over ons / Open source / Team / Werkwijze / ISO / Identiteit.
  • Both Way of Work / Werkwijze links open https://docs.conduction.nl/WayOfWork/way-of-work/.

The Conduction column was advertising '/academy?type=case-study' as
'Case studies', but case studies live on the Academy filter and
'Way of Work' is now the canonical 'how Conduction operates' surface
on docs.conduction.nl. Point readers at the handbook landing instead
of the academy filter.

- docusaurus.config.js: footer 'Case studies' -> 'Way of Work',
  href https://docs.conduction.nl/WayOfWork/way-of-work/.
- i18n/nl: add NL translation 'Werkwijze' for the new label.
@MWest2020

Copy link
Copy Markdown
Member

Review — Replace 'Case studies' footer link with 'Way of Work'

Verdict: 🟢 APPROVE — Target URL is live (HTTP 200); enige overgebleven 'case-study' match in de codebase staat in docusaurus.config.js zelf — precies de regel die deze PR verwijdert; NL i18n entry klopt; CI groen.

Wat goed gaat

Heldere PR body met motivatie (content-led vs company-led link). Test plan is concreet en verifieerbaar. NL i18n entry Werkwijze matcht semantisch perfect met Way of Work — geen letterlijke vertaling maar de Nederlandse term die ook door overheidsorganisaties gebruikt wordt. Description in de i18n entry verwijst correct naar de target URL. Geen orphan-references in de codebase.

Findings

1. 🟢 Minor — Geen NL i18n key opruimen — geen stale 'Case studies' entry — i18n/nl/docusaurus-theme-classic/footer.json

Verificatie: de NL footer.json op development heeft geen sleutel die met 'case' / 'study' / 'academy' begint. De toegevoegde link.item.label.Way of Work is volledig; er valt niets weg op te ruimen.

Impact: Geen.

Suggested fix: Geen actie nodig.

2. 🟢 Minor — Target URL is live (HTTP 200)

curl -I https://docs.conduction.nl/WayOfWork/way-of-work/ levert HTTP/2 200 met last-modified: Sat, 09 May 2026 05:55:35 GMT (recent gerebuild zoals PR body claimt).

Impact: Footer-link werkt na merge.

Suggested fix: Geen.


Geconsolideerde review via /review-pr — Thorough mode.

MWest2020
MWest2020 previously approved these changes May 11, 2026

@MWest2020 MWest2020 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zie consolidated review comment voor complimenten, findings en suggested fixes.

@rubenvdlinde rubenvdlinde merged commit b0d6b58 into development May 25, 2026
6 checks passed
@rubenvdlinde rubenvdlinde deleted the feature/footer-way-of-work branch May 25, 2026 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants