Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.
This repository was archived by the owner on May 29, 2026. It is now read-only.

[LOW] L3: Vote-keyword parser case sensitivity bug — mixed-case VOTE_KEYWORDS keys cause silent vote-parse failure #321

Description

@rubenvdlinde

Severity: LOW

Location: lib/Controller/DashboardController.php:55-56, 74-75

Description:
DashboardController uses docblock-style annotations (@NoAdminRequired) instead of PHP 8 attributes (#[NoAdminRequired]). All other controllers in the app use the PHP 8 attribute form. Docblock annotations are deprecated as of Nextcloud 28+ and will eventually stop being processed.

Suggested fix:
Replace the docblock annotations on DashboardController with their PHP 8 attribute equivalents (#[NoAdminRequired], #[PublicPage] where applicable) to be consistent with the rest of the codebase.

Source: deep team-reviewer pass 2026-05-27

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions