Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

fix(security): membership authz, tally bounds, public-state filtering, workflow default-deny, published-only ORI#330

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/security-auth-visibility
May 27, 2026
Merged

fix(security): membership authz, tally bounds, public-state filtering, workflow default-deny, published-only ORI#330
rubenvdlinde merged 1 commit into
developmentfrom
fix/security-auth-visibility

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

Fixes 7 security/correctness issues found in the quality-loop review.

Test plan

  • testPublishAgendaNotifiesOnlyActiveParticipants updated to stub the new find() call for the full meeting object
  • PHP syntax clean on all 5 changed service/controller files
  • Run composer test (unit suite — VotingServiceTest is skipped per issue Broken: 21 unit tests fail due to ObjectService stub/real-signature mismatch #90)
  • Verify GET /api/ori/v1/events returns only published meetings
  • Verify GET /api/ori/v1/voteevents/<draft-id> returns 404
  • Verify anonymous publicState on a secret or non-published round returns 404
  • Verify castVote with a participant not in the meeting returns 403
  • Verify saveShowOfHandsTally with counts > participant count returns 400

…, workflow default-deny, published-only ORI

Closes #300 castVote now verifies caller's participant is a member of the
meeting that owns the voting round before accepting the vote.

Closes #302 saveShowOfHandsTally validates submitted counts against active
participant count; rejects tallies that exceed meeting membership.

Closes #303 getPublicState returns null (404) for secret rounds and for
rounds whose lifecycle is not 'published', preventing anonymous projection
display of draft or secret ballots.

Closes #313 WorkflowService::isTransitionAllowed evaluates domain allow-flags
(allowPause / allowAdjourn) before the chairOnlyTransitions list so domain
restrictions cannot be short-circuited by a chair-only match.

Closes #314 getDomainWorkflow falls back to RESTRICTED_WORKFLOW (quorum
enforced, no pause, no adjourn) for unrecognized domains instead of the
permissive 'operations' config.

Closes #315 AgendaService::publishAgenda and reviseAgenda now read the full
meeting object before saveObject to prevent partial updates from wiping
required fields.

Closes #316 OriController::index and ::show filter to lifecycle=='published'
so anonymous ORI callers never see draft or unpublished objects.

Closes #317 MotionService::transitionLifecycle rejects empty actorId to
prevent unauthenticated DI-path callers from bypassing controller auth guards.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant