Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

feat(adr-036): migrate App.vue to v2 kind-tagged registry prop#332

Merged
rubenvdlinde merged 1 commit into
developmentfrom
feat/adr-036-registry-prop
May 27, 2026
Merged

feat(adr-036): migrate App.vue to v2 kind-tagged registry prop#332
rubenvdlinde merged 1 commit into
developmentfrom
feat/adr-036-registry-prop

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the deprecated `customComponents` prop on `CnAppRoot` and `CnObjectSidebar` with the v2 `registry` prop (ADR-036, nextcloud-vue#458, OR #1988).
  • Consolidates `src/customComponents.js` (tab components) into `src/registry.js`, removing the split between the two files. All entries are wrapped as `{ kind: 'page', component }` via the `page()` helper function.
  • Updates `src/main.js` to import `registry` and pass `registryProp` under the `registry` key.
  • Updates `src/App.vue` template bindings (`:registry="registry"` on both `CnAppRoot` and `CnObjectSidebar`) and the props block (`registry` replaces `customComponents`), with JSDoc updated to reference ADR-036.
  • Version bumped to `0.1.5`.

Test plan

  • Build passes (`npm run build`) — confirmed clean (bundle-size warnings are pre-existing)
  • Load decidesk in dev environment; verify the main app shell renders all pages including LiveMeeting and detail tabs
  • Confirm no Vue console warnings about unknown `customComponents` prop on `CnAppRoot`
  • Confirm sidebar tabs (GovernanceBodyMembersTab, MeetingAgendaTab, etc.) still render in detail views

References

  • ADR-036 (kind-tagged registry prop)
  • nextcloud-vue#458
  • OR #1988

Replace the deprecated customComponents prop with the v2 registry prop
on CnAppRoot (ADR-036). Each page component is wrapped as
{ kind: 'page', component } via src/registry.js.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant