This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(security): ParticipantResolver — replace five broken participant filters (C3/H1/H2)#335
Merged
Merged
Conversation
…ent @self.relations.meeting participant filters (C3/H1/H2) The participant schema has no meeting relation; five sites were filtering by '@self.relations.meeting' which silently returned empty results, making all chair/secretary and participant membership checks fail-open. Introduces ParticipantResolver service with canonical meeting→governanceBody→participant path (mirrors VotingService.checkQuorum) and routes AgendaController, LiveMeetingController, MinutesController, VotingService (castVote preset and saveShowOfHandsTally), and DecideskToolProvider.requireParticipantOrAdmin through it.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParticipantResolverservice with the canonicalmeeting → governanceBody → participantspath (mirrorsVotingService::checkQuorumwhich was the only correct site)@self.relations.meetingparticipant-filter sites through it:AgendaController,LiveMeetingController,MinutesController,VotingService(castVote member-check + saveShowOfHandsTally count),DecideskToolProvider::requireParticipantOrAdmingovernanceBodyId: $meetingId→ correct governance-body lookup)Findings fixed
@self.relations.meetingdoesn't exist on participant schema (5 sites)requireParticipantOrAdminused stalemeeting['participants']arrayTest plan
vendor/bin/phpunit --configuration phpunit-unit.xml --no-coveragepassesvendor/bin/phpstan analyse lib/passesvendor/bin/phpcs lib/Service/ParticipantResolver.php lib/Controller/AgendaController.php lib/Controller/LiveMeetingController.php lib/Controller/MinutesController.php lib/Service/VotingService.php lib/Mcp/DecideskToolProvider.phpno errors