This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(cleanup): admin delegation bypass, ORI lifecycle gate, dead try/catch, find() named args (M1-M4)#338
Merged
Merged
Conversation
…atch, find() named args (M1-M4/L2) - M1: DelegationController revoke/expire — add IGroupManager; pass null (skip ownership check) for admins, callerUid for non-admins, enabling admins to revoke/expire any delegation without ownership error - M2: OriController::show — lifecycle gate now uses null-check so schemas without a lifecycle/status field (votes, persons, etc.) pass through instead of returning 404 on every request - M3: OriPublicationService::publish — rethrow \Throwable after logging so the outer VotingService catch can attach oriPublicationError to the round data (previously swallowed all exceptions, making outer catch dead) - M4: Standardize find() to named-arg pattern in DelegationService, TaskService, MotionCoauthorService — remove setRegister/setSchema prefix - L2: already resolved by PR A (AgendaController requireChairOrAdmin no longer uses findAll with register/schema in filters[]) - L3: already present in MailReplyHandler::signMailEntry (@SPEC tag exists) - Fix Application.php DI: add groupManager to DelegationController wiring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan