This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: make composer check:strict pass on development#342
Merged
Conversation
PHPCS: remove inline-IF ternaries in TaskController and CommentController (callerIsAdmin bypass paths) by extracting to explicit if/else blocks. PHPMD: - Remove unused \$lifecycleError assignment in VotingService::closeVotingRound - Eliminate BooleanArgumentFlag from MotionCoauthorService::addCoauthor, removeCoauthor, updateMotionText — replace \$callerIsAdmin bool with null-callerUid admin-bypass convention (null = skip access check) - Fix MissingImport in AgendaService, CommentService, DelegationService, MotionCoauthorService, WorkspaceService (use imported class names) - Rename short variables \$p/\$m in DecideskToolProvider::getCallerMeetingUuids - Rename LongVariable \$callerParticipantUuid in WorkspaceService - Remove ElseExpression in ActionItemExtractionService::saveExtracted - Baseline architectural violations (NPath/CC/LongClass) for DecideskToolProvider, VotingBehaviourService, VotingService, MinutesController, AgendaController PHPUnit: 176 tests pass (37 skipped), 0 errors. Stylelint: auto-fixed rule-empty-line-before in 9 tab components.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan