This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: Resolve CI quality check failures#12
Merged
Conversation
…ters - MetricsController: Use sprintf() for Prometheus info label to stay under 125-char line limit - MetricsController: Fix countTable() named param (table -> tableName) - UserAttributeResolver: Fix str_starts_with/str_ends_with named params (prefix/suffix -> needle) - TileMapper: Add @extends QBMapper<Tile> template annotation - Add ramsey/uuid as explicit dependency (used by TemplateService and AdminTemplateService)
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (103 total)
npm dependencies (342 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
The anchore/scan-action/download-grype@v5 action installs grype to a toolcache path that is not on PATH. Use the step output `cmd` to reference the correct binary path.
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (103 total)
npm dependencies (342 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
The gen-mapping and helper-validator-identifier CVEs are false positives caused by grype matching unscoped CycloneDX names against typosquatting advisories. The actual deps are scoped (@jridgewell/gen-mapping, etc).
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (103 total)
npm dependencies (342 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
rjzondervan
approved these changes
Mar 20, 2026
| "require": { | ||
| "php": "^8.1" | ||
| "php": "^8.1", | ||
| "ramsey/uuid": "^4.9" |
Member
There was a problem hiding this comment.
Small check, elsewhere Symfony/Uuid is used (IIRC because it was in Nextcloud already), why do we require ramsey/uuid here?
8 tasks
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
fix: Resolve CI quality check failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricsController.php(127 chars, limit 125) by extracting Prometheus labels into asprintf()callMetricsController::countTable(table:)->countTable(tableName:)(matches actual parameter name)str_starts_with(prefix:)->str_starts_with(needle:)inUserAttributeResolverstr_ends_with(suffix:)->str_ends_with(needle:)inUserAttributeResolver@extends QBMapper<Tile>template annotation toTileMapperramsey/uuidas explicit dependency (used byTemplateServiceandAdminTemplateService)Test plan