This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(dashboard-switcher): slide-in sidebar with 3 sections#59
Merged
rubenvdlinde merged 1 commit intoApr 30, 2026
Merged
Conversation
rubenvdlinde
added
the
ready-for-code-review
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-30 19:09 UTC
Download the full PDF report from the workflow artifacts.
…ITCH-001..007 - Add DashboardSwitcherSidebar.vue with three conditional sections (matched group / default / personal) - Render via IconRenderer for all icons, no inline branching - Click semantics: emit update:open(false) then switch(id, source) where source discriminates by section - Active-item highlight with --color-primary-element-light background - Personal rows show hover-revealed delete button (CSS display toggle) emitting delete-dashboard(id) - + New Dashboard button gated on allowUserDashboards, emits update:open(false) then create-dashboard - Slide-in animation via transform: translateX(-100%→0) over 0.25s ease - Add SidebarBackdrop.vue for click-to-close surface - Vitest tests cover all 7 REQs: section visibility, emit order, active highlight, delete no-switch, create button gating, icon rendering - Add i18n keys: My Dashboards, + New Dashboard
rubenvdlinde
force-pushed
the
feature/impl-dashboard-switcher-sidebar
branch
from
2854483 to
105e5ca
Compare
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-30 19:13 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Apr 30, 2026
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
…ITCH-001..007 (#59) - Add DashboardSwitcherSidebar.vue with three conditional sections (matched group / default / personal) - Render via IconRenderer for all icons, no inline branching - Click semantics: emit update:open(false) then switch(id, source) where source discriminates by section - Active-item highlight with --color-primary-element-light background - Personal rows show hover-revealed delete button (CSS display toggle) emitting delete-dashboard(id) - + New Dashboard button gated on allowUserDashboards, emits update:open(false) then create-dashboard - Slide-in animation via transform: translateX(-100%→0) over 0.25s ease - Add SidebarBackdrop.vue for click-to-close surface - Vitest tests cover all 7 REQs: section visibility, emit order, active highlight, delete no-switch, create button gating, icon rendering - Add i18n keys: My Dashboards, + New Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements REQ-SWITCH-001..007 per spec on development. New DashboardSwitcherSidebar.vue with 3 conditional sections (matched group / default / personal), hover-reveal delete on personal items, +New Dashboard gated on allowUserDashboards, slide-in animation. Uses IconRenderer for icons (no inline branching). Vitest covers all 7 REQs. Will be wired into runtime-shell (later).