This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(dashboards): active-dashboard resolution chain#62
Merged
rubenvdlinde merged 1 commit intoApr 30, 2026
Conversation
rubenvdlinde
added
the
ready-for-code-review
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-30 19:52 UTC
Download the full PDF report from the workflow artifacts.
….019 Implements the 7-step precedence resolver in DashboardService with stale-pref auto-clear (REQ-DASH-018). Adds setActivePreference() and the POST /api/dashboards/active write endpoint (REQ-DASH-019). PageController refactored to call resolveActiveDashboard() and push the resolved dashboard via InitialStateBuilder. PHPUnit covers all 7 steps, stale-pref, cross-group invalidation, and empty-state. Pre-existing issues fixed: className: named-param on createMock(), willReturn double-stub in AllowFlagTest.
rubenvdlinde
force-pushed
the
feature/impl-active-dashboard-resolution
branch
from
c051162 to
b6fcb2b
Compare
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-30 20:05 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Apr 30, 2026
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
….019 (#62) Implements the 7-step precedence resolver in DashboardService with stale-pref auto-clear (REQ-DASH-018). Adds setActivePreference() and the POST /api/dashboards/active write endpoint (REQ-DASH-019). PageController refactored to call resolveActiveDashboard() and push the resolved dashboard via InitialStateBuilder. PHPUnit covers all 7 steps, stale-pref, cross-group invalidation, and empty-state. Pre-existing issues fixed: className: named-param on createMock(), willReturn double-stub in AllowFlagTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements REQ-DASH-018..019 per spec on development. 7-step precedence resolver in DashboardService with stale-pref auto-clear. New POST /api/dashboards/active write endpoint. PageController refactored to use resolver + push resolved dashboard via InitialStateBuilder. PHPUnit covers all 7 steps + stale-pref + empty-state.