This repository was archived by the owner on May 29, 2026. It is now read-only.
chore(ux): Settings menu opens NcAppSettingsDialog (action: user-settings)#34
Merged
Merged
Conversation
…ings) - Change SettingsMenu entry to action: "user-settings" / icon: "Cog"; drop route + section. CnAppNav invokes cnOpenUserSettings inject (CnAppRoot) which opens NcAppSettingsDialog. The Settings type:'settings' page stays for direct-URL /settings access. - App.vue: import NcAppSettingsSection; add #user-settings slot to CnAppRoot with a placeholder NcAppSettingsSection — replace with real settings content when scaffolding a new app. - README: one-line note in the manifest/menu section documenting the pattern. - Upgrade @conduction/nextcloud-vue from beta.30 → beta.35 (schema 1.5.0) to support action: "user-settings" — package.json already declared ^1.0.0-beta.35; node_modules was behind. - validate-manifest PASS (0 Ajv errors, schema 1.5.0); lint 0 errors; build succeeds.
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 428/428 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-12 12:44 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/manifest.json:SettingsMenuentry changed fromroute: "Settings" / section: "settings"toaction: "user-settings" / icon: "Cog". CnAppNav wires manifest entries withaction: "user-settings"to thecnOpenUserSettingsinject (provided by CnAppRoot), which opens the hostedNcAppSettingsDialog. TheSettingstype: "settings"page is retained — direct URL access to/settingsstill works.src/App.vue: importsNcAppSettingsSectionand adds a#user-settingsslot to<CnAppRoot>with a placeholder section. New apps clone the template and replace the placeholder with their real settings content.README.md: one-line note in the manifest/menu section: "TheSettingsmenu entry usesaction: "user-settings"→ opensNcAppSettingsDialogvia CnAppRoot'scnOpenUserSettingsinject; feed your settings sections intoApp.vue's#user-settingsslot."@conduction/nextcloud-vuebumped to beta.35 (schema 1.5.0) in node_modules —package.jsonalready declared^1.0.0-beta.35; installed version was behind.Test plan
NcAppSettingsDialogwith the "General" placeholder section/apps/app-template/settingsstill renders the manifest-driven settings pagenode tests/validate-manifest.js(=npm run check:manifest) → PASS (0 Ajv errors, schema 1.5.0)npm run lint→ 0 errorsnpm run build→ succeeds