This repository was archived by the owner on May 29, 2026. It is now read-only.
docs(readme): declare root configs as fleet canonical#47
Merged
Conversation
phpcs.xml, phpmd.xml, psalm.xml, phpstan.neon, and phpstan-bootstrap.php in this repo are the source of truth for the Conduction PHP fleet. Apps mirror these files; per-app deviations belong in baselines, not in the canonical files themselves. This unblocks a fleetwide template-sync flow that propagates root-config changes from here to all 17 PHP apps in apps-extra/.
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ✅ 100/100 | |||
| npm | ✅ | ❌ 2/684 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-21 18:39 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpcs.xml,phpmd.xml,psalm.xml,phpstan.neon, andphpstan-bootstrap.phpas the fleet canonical for all Conduction PHP apps.phpstan-baseline.neon,psalm-baseline.xml), not in the canonical files themselves.apps-extra/.Context
Recon across the fleet (17 PHP apps) showed effectively zero shared quality config — every app drifted its own copy of
phpcs.xmletc. The nextcloud-app-template root configs already match the newest-scaffolded apps (deskdesk byte-for-byte forphpcs.xml; 4-way hash match forphpstan.neonacross template + deskdesk + planix + shillinq). This PR formalises that the template IS the canonical surface — no file changes to the configs themselves, just the convention statement.Phase 0 of a fleetwide consolidation. Follow-ups will (a) clean drift outliers across the 17 apps, (b) pilot the sync on deskdesk, (c) fan out fleet-wide, (d) wire up a
repo-file-syncworkflow here so future canonical changes auto-PR across the fleet.Test plan