This repository was archived by the owner on May 29, 2026. It is now read-only.
chore(canonical): pilot-refinements absorbed from Phase 2-fleet rollout#51
Merged
Merged
Conversation
Four refinements identified during the 16-app fleet rollout (Phase 2), absorbed back into the canonical so the next round of fleet syncs is cleaner: 1. psalm.xml ignoreFiles adds lib/Resources/template — mirrors the existing phpcs/phpstan excludes for apps shipping a verbatim template snapshot (openbuilt). No-op for apps without the directory. 2. psalm.xml gains errorBaseline="psalm-baseline.xml" + ships an empty psalm-baseline.xml as the canonical tracked-debt entry point. openregister/mydash/opencatalogi/docudesk already used this pattern ad-hoc; making it canonical means every app's psalm tracked debt has a uniform home. Mirrors the phpstan-baseline.neon pattern from nextcloud-app-template #49. 3. psalm.xml referencedClass list gains OCA\OpenRegister\Service\RiskLevelService and OCA\OpenRegister\Db\EntityRelationMapper. docudesk surfaced these as needed-but-missing; promoting fleetwide so per-app additions aren't required (per the no-per-app-rules directive). 4. phpstan.neon ignoreErrors gains the OC\Security\CSRF\ family. Pipelinq surfaced CsrfTokenManager during the sync (no OCP equivalent yet); this is server-internal and applies fleetwide.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ✅ 100/100 | |||
| npm | ✅ | ❌ 2/684 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-21 21:29 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four refinements identified during the 16-app Phase 2 fleet rollout, absorbed back into the canonical so future syncs are cleaner.
lib/Resources/template— mirrors the existing phpcs/phpstan excludes for apps shipping a verbatim template snapshot (openbuilt). No-op for apps without the directory.errorBaseline="psalm-baseline.xml"+ ships an emptypsalm-baseline.xmlas the canonical tracked-debt entry point. openregister/mydash/opencatalogi/docudesk already used this pattern ad-hoc; making it canonical means every app's psalm tracked debt has a uniform home. Mirrors thephpstan-baseline.neonpattern from chore(canonical): ship baseline-include pattern + pilot fixes #49.OCA\OpenRegister\Service\RiskLevelServiceandOCA\OpenRegister\Db\EntityRelationMapper. docudesk surfaced these as needed-but-missing; promoting fleetwide so per-app additions aren't required (per the no-per-app-rules directive).OC\Security\CSRF\family. pipelinq surfacedCsrfTokenManagerduring the sync (no OCP equivalent yet); this is server-internal and applies fleetwide.Test plan
lib/