This repository was archived by the owner on May 29, 2026. It is now read-only.
docs(canonical): extend fleet sync + tier policy + extras audit#55
Merged
Conversation
Three deliverables:
1. **Extends `sync-canonical-fleet.yml`** to add 6 more byte-for-byte
canonical files alongside the existing PHP-tooling set (phpcs/phpmd/
psalm/phpstan + custom sniffs):
Frontend / JS quality tooling
- stylelint.config.js
- eslint.config.js
- .prettierrc
Git / npm / Node toolchain
- .gitattributes
- .npmrc
- .nvmrc
Workflow path-triggers + header comment updated to match. Fleet
sync will fire on changes to any of these going forward.
2. **`docs/canonical-files.md`** — user-facing policy doc explaining
the 5-tier categorization (strict canonical, template-based,
app-specific, gitignored, per-app extras), how a canonical change
flows from edit → fleet PRs, and what's deliberately out of scope
(ExApp sidecars + external repos). References ADR-033 as the
authoritative architecture decision.
3. **`docs/fleet-extras-audit.md`** — snapshot of every root-directory
file in fleet apps that's NOT in this template, scored by frequency
(≥6 / 3-5 / 1-2 apps) with a per-file decision: promote to template,
keep app-private, move out of repo root, delete, or out of scope.
Calls out the per-app cleanup candidates app-by-app (softwarecatalog
is the heavy hitter with ~30 root scratch files).
Drift baseline from the audit:
- phpcs.xml: 20/21 apps drifted from template
- phpmd.xml: 19/20 drifted
- psalm.xml: 21/21 ALL drifted (zero matches)
- eslint.config.js: 14/14 ALL drifted
- phpstan.neon: 13/16 drifted
- phpunit.xml: 12/16 drifted
The agent's recent `chore: sync canonical root configs` PR series
(deskdesk#33, decidesk#243, shillinq#300) is the in-flight rollout
that closes this drift. The doc captures the policy that work follows.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ❌ 2/684 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-23 06:24 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three deliverables to keep fleet configuration files in line and document the policy.
1. Extend
sync-canonical-fleet.ymlAdds 6 more byte-for-byte canonical files alongside the existing PHP-tooling set (phpcs/phpmd/psalm/phpstan + custom sniffs):
Frontend / JS quality tooling:
stylelint.config.jseslint.config.js.prettierrcGit / npm / Node toolchain:
.gitattributes.npmrc.nvmrcWorkflow path-triggers + header comment updated to match. Fleet sync will fire on changes to any of these going forward.
2. New:
docs/canonical-files.mdUser-facing policy doc explaining the 5-tier categorization:
Documents how a canonical change flows from template edit → fleet PRs, the allowed cosmetic deviations (phpcs.xml
<description>+ phpmd.xml ruleset name), and what's deliberately out of scope (ExApp sidecars + external repos). References ADR-033 as the authoritative architecture decision.3. New:
docs/fleet-extras-audit.mdSnapshot of every root-directory file in fleet apps that's not in this template, scored by frequency (≥6 / 3-5 / 1-2 apps) with a per-file decision: promote to template, keep app-private, move out of repo root, delete, or out of scope. Calls out per-app cleanup candidates app-by-app.
Drift baseline from the audit
The agent's recent
chore: sync canonical root configsPR series (deskdesk#33, decidesk#243, shillinq#300) is the in-flight rollout that closes this drift. The doc captures the policy that work follows.Heaviest cleanup target
softwarecataloghas ~30 root-scratch files (debug PHP scripts, test shell scripts, AMEF/ArchiMate work-notes). Detailed list in the audit doc — recommended path is move toscripts/dev/anddocs/notes/, not delete.