This repository was archived by the owner on May 29, 2026. It is now read-only.
chore: retire GHA fleet sync (move to hydra local-dev) + composer platform 8.3#59
Merged
Merged
Conversation
…tform 8.3 Security architecture: a single GHA-secret PAT with repo:write on 16 fleet apps is a credential blast-radius we don't want to defend. The canonical sync moves to hydra/scripts/fleet-sync/ where it runs locally with each developer's own gh auth — no shared token, no GHA secret to rotate, no third-party action with broad fleet access. Changes: - Delete .github/workflows/sync-canonical-to-fleet.yml + .github/sync-canonical-fleet.yml (moved to hydra/scripts/fleet-sync/ in a separate hydra PR). - composer.json config.platform.php: 8.1 -> 8.3. require.php was bumped fleet-wide last night (PR #54 here, plus 18 sibling PRs across the fleet); the platform pin keeps composer's resolver consistent with the runtime constraint. - docs/canonical-files.md updated to describe the new local-sync flow, the security rationale, and the hydra location. Issue #58 (FLEET_SYNC_TOKEN setup) becomes obsolete and will be closed.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ❌ 2/684 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-23 07:14 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security move
A single GHA-secret PAT with repo:write on 16 fleet apps is a credential blast-radius we don't want to defend. The canonical sync moves to
hydra/scripts/fleet-sync/where it runs locally with each developer's owngh auth— no shared token, no GHA secret to rotate, no third-party action with broad fleet access.Trade-off: someone has to run the sync manually after a canonical change. That's a small cost paid for a real security improvement.
Changes
.github/workflows/sync-canonical-to-fleet.yml+.github/sync-canonical-fleet.yml(moved to hydra in a sibling PR).composer.jsonconfig.platform.php: 8.1 → 8.3.require.phpwas bumped fleet-wide yesterday (chore(deps): bump PHP requirement to ^8.3 #54 here plus 18 sibling PRs across the fleet); the platform pin keeps composer's resolver consistent with the runtime constraint.docs/canonical-files.mdupdated to describe the new local-sync flow, the security rationale, and the hydra location.Closes
Issue #58 (FLEET_SYNC_TOKEN secret setup) becomes obsolete — closing once this lands.
Sibling PR
The hydra side (the actual sync script + repos list + README) is coming as a separate PR on
ConductionNL/hydra.