This repository was archived by the owner on May 29, 2026. It is now read-only.
docs(openspec): bring spec-coverage to zero (gate-16)#65
Merged
Conversation
Annotate the 29 uncovered methods so every observable capability in the scaffold carries an @SPEC reference. Because this is the fleet template, the balance struck here is the reference for new apps. Backend (16): annotate to the existing example specs / ADR-023. Frontend (10): two new example capability specs — frontend-data-stores (Pinia object/settings stores + boot initializer) and scaffold-components (cell-renderer, modal, widget runtime behaviour). Excluded (3, App.vue): provide() channel wiring, the i18n translate wrapper, and the window.OC permissions passthrough — the canonical plumbing-only exclude examples for template-derived apps. Gate-16 now reports 0 uncovered methods.
rubenvdlinde
added
yolo
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 597/597 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 20:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
nextcloud-app-templateto 0 uncovered spec-coverage methods (gate-16), down from 29 (16 backend + 13 frontend). Since this is the fleet SCAFFOLD repo, the@specexamples written here are the reference new apps copy.Breakdown (29 methods)
Annotated to existing specs (23):
DashboardController::{page,catchAll}-> dashboard-page;SettingsController::{index,create,load}+SettingsService::{getSettings,updateSettings,loadConfiguration}-> settings-management;DeepLinkRegistrationListener::handle-> deep-linking;InitializeSettings::run-> configuration-initialization;InitializeActions::run+ActionAuthService::{requireAction,can,getAllowedGroups,getMatrix,setMatrix}-> ADR-023.StatusBadge::normalised,ExampleModal::{onConfirm,onCancel},ExampleWidget::mounted-> newscaffold-componentscap;settings.js::{fetchSettings,saveSettings}-> newfrontend-data-storescap.Reverse-spec'd - two new example capability specs:
openspec/specs/frontend-data-stores/spec.md- Pinia object store (configure/registerObjectType/fetchObjects), settings store, andinitializeStoresboot helper (5 REQs).openspec/specs/scaffold-components/spec.md- runtime behaviour of the cell-renderer / modal / widget demos (3 REQs).Excluded - pure plumbing (3, all in
App.vue):provide()- reactive sidebar-state channel wiring.translateForApp()- i18n wrapper binding@nextcloud/l10ntranslate to the app id.permissions-window.OC.currentUser.permissionspassthrough.These three are intentionally the canonical excludable examples for the fleet.
Verification
python3 csc.py <worktree> --mode report->uncovered_count: 0.@specreferenced paths resolve; PHP files lint clean.