This repository was archived by the owner on May 29, 2026. It is now read-only.
chore(nav): adopt three-section nav model + bump nc-vue to beta.97#66
Merged
Conversation
Adopt CnAppNav three-section nav: Documentation and Features & roadmap move to section:"footer" (bottom-pinned). Remove the user-settings menu item since the new nav auto-prepends a Personal settings entry. Bump @conduction/nextcloud-vue to 1.0.0-beta.97, which ships the new CnAppNav (the old bundled one drops section:"footer" items). Patch info.xml.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 596/596 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 20:39 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DocumentationandFeatures & roadmapmenu items move to"section": "footer"(bottom-pinned)Settingsmenu item ("action": "user-settings") — the new nav auto-prepends a Personal settings entry@conduction/nextcloud-vuefrom beta.66 to1.0.0-beta.97(the new CnAppNav; the old bundled one dropssection:"footer"items, so the manifest change + dep bump must land together)appinfo/info.xml0.1.0 -> 0.1.1This is the scaffold new apps copy, so it models best practice. Proven on pipelinq + openconnector.
Test plan