This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: critical scaffold — importFromApp arity, version drift, deep link, double repair (C1+C3+H1+H2)#94
Merged
Conversation
…ep link, double repair
- C1: SettingsService::loadConfiguration now reads app_template_register.json from disk,
extracts info.version, and calls importFromApp(appId, data, version, force) with all 4
required arguments. Previous 2-arg call would throw on any OpenRegister instance.
- C3: HealthController and MetricsController hardcoded version '0.1.0'. Both now inject
IAppManager and call getAppVersion(APP_ID) so version always tracks info.xml.
- H1: DeepLinkRegistrationListener urlTemplate changed from '/apps/app-template/#/examples/{uuid}'
to '/apps/app-template/examples/{uuid}' — hash-fragment URLs are not valid deep-link patterns
and break OpenRegister's unified search result navigation.
- H2: Application::register() was calling both registerRepairStep(InitializeSettings) AND
info.xml declares the same step — causing double-execution. Removed the PHP-side call;
info.xml repair-steps is the canonical registration path.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
rubenvdlinde
added a commit
that referenced
this pull request
May 28, 2026
…ep link, double repair (#94) - C1: SettingsService::loadConfiguration now reads app_template_register.json from disk, extracts info.version, and calls importFromApp(appId, data, version, force) with all 4 required arguments. Previous 2-arg call would throw on any OpenRegister instance. - C3: HealthController and MetricsController hardcoded version '0.1.0'. Both now inject IAppManager and call getAppVersion(APP_ID) so version always tracks info.xml. - H1: DeepLinkRegistrationListener urlTemplate changed from '/apps/app-template/#/examples/{uuid}' to '/apps/app-template/examples/{uuid}' — hash-fragment URLs are not valid deep-link patterns and break OpenRegister's unified search result navigation. - H2: Application::register() was calling both registerRepairStep(InitializeSettings) AND info.xml declares the same step — causing double-execution. Removed the PHP-side call; info.xml repair-steps is the canonical registration path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan