This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: CSRF policy, orphan store removal, test dir consolidation (C2+M1+M3+M4+L1)#95
Merged
Merged
Conversation
…+M3+M4+L1) - C2/L1: Drop @NoCSRFRequired from PreferencesController setPreference and getPreference — per project policy, @NoCSRFRequired is OR-only. Both methods are user-session endpoints with CSRF protection required. - M4: Add @NoCSRFRequired to MetricsController::index with explicit rationale comment — Prometheus scrapers have no CSRF token; admin-auth replaces it per ADR-006. This is the documented exception to the policy. - M1: Delete src/store/store.js and src/store/modules/settings.js — these were orphan bespoke Pinia store files with no importers anywhere in the codebase. - M3: Consolidate tests/Unit/ (capital U) into tests/unit/ (lowercase) — both directories existed simultaneously with disjoint content. phpunit.xml updated to reference only tests/unit/ going forward.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
rubenvdlinde
added a commit
that referenced
this pull request
May 28, 2026
…+M3+M4+L1) (#95) - C2/L1: Drop @NoCSRFRequired from PreferencesController setPreference and getPreference — per project policy, @NoCSRFRequired is OR-only. Both methods are user-session endpoints with CSRF protection required. - M4: Add @NoCSRFRequired to MetricsController::index with explicit rationale comment — Prometheus scrapers have no CSRF token; admin-auth replaces it per ADR-006. This is the documented exception to the policy. - M1: Delete src/store/store.js and src/store/modules/settings.js — these were orphan bespoke Pinia store files with no importers anywhere in the codebase. - M3: Consolidate tests/Unit/ (capital U) into tests/unit/ (lowercase) — both directories existed simultaneously with disjoint content. phpunit.xml updated to reference only tests/unit/ going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan