This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: openregister dependency, DI settings, SPDX tags, manifest cleanup (H3+L2+L3+L4+L5)#96
Merged
Merged
Conversation
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
…st cleanup (H3+L2+L3+L4+L5) - H3: appinfo/info.xml now declares <app>openregister</app> dependency, matching manifest.json which already listed "openregister" in dependencies. Without this NC won't enforce the OR dependency on install. - L2/L3: AdminSettings::getForm injects IInitialStateService and calls provideInitialState to push the app version to the frontend CSP-safely. The service-locator call (\OC::$server->get()) in templates/settings/admin.php is removed — state is now injected by the DI'd class instead. - L4: Added SPDX-FileCopyrightText and SPDX-License-Identifier to lib/Repair/InitializeActions.php and lib/Service/ActionAuthService.php (both were missing these required headers). - L5: Removed placeholder @SPEC tag pointing to example-change/tasks.md#task-N from Application.php docblock (was a scaffold comment, not a real spec link). - Manifest cleanup: remove hardcoded isUpToDate:true and showUpdateButton:false from version-info widget props (these are dynamic values the widget should determine itself from injected state, not static manifest props).
rubenvdlinde
force-pushed
the
fix/pr-c-hygiene
branch
from
9c3b122 to
15a32a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan