This repository was archived by the owner on May 29, 2026. It is now read-only.
test: Gate-19 e2e spec-coverage — 0 uncovered (32 tests pass)#112
Merged
Conversation
- Add Playwright test suite covering all testable UI scenarios across 5 specs: admin-settings, token-editor-ui, token-import-export, theming-sync-dialog, and token-set-apply-dialog (32 tests, all pass) - Annotate 13 whole-spec @e2e exclude markers for pure backend/CSS/docs specs (component-tokens, css-architecture, custom-css-overrides, docs-content, extended-token-sets, hide-slogan, menu-labels, nextcloud-variable-mapping, nl-design, prometheus-metrics, theming-sync, token-set-dropdown, token-sets, token-sync-workflow, vng-token-set) - Annotate per-scenario @e2e exclude markers for untestable scenarios in the 5 UI-surface specs (non-admin session, API internals, file mutations) - Fix TokenSetPreviewService wrong CSS paths (css/defaults.css → css/systems/nldesign/defaults.css, css/overrides.css → css/systems/nldesign/overrides.css) — caused tokenset-preview endpoint to always return resolved:[] making the apply dialog never appear - Fix missing .nldesign-dialog-overlay CSS (position: fixed, inset: 0, z-index: 10000) and .nldesign-dialog-actions sticky positioning so the Cancel button is reachable in the viewport during tests - Gate-19 result: 0 uncovered, 31 covered, 408 excluded (439 total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/e2e/spec-coverage/covering all testable UI scenarios across 5 specs (admin-settings, token-editor-ui, token-import-export, theming-sync-dialog, token-set-apply-dialog) — 32 tests, all passing@e2e excludemarkers for pure backend/CSS/docs/API specs with no testable UI surface@e2e excludemarkers for untestable scenarios in the 5 UI-surface specs (non-admin sessions, API internals, shared-env-mutating operations)Bug fixes included
Two production bugs found and fixed while writing the tests:
TokenSetPreviewServicewrong CSS paths —getResolvedColors()looked forcss/defaults.cssandcss/overrides.cssbut those files live atcss/systems/nldesign/defaults.cssandcss/systems/nldesign/overrides.css. This caused the/settings/tokenset-preview/{id}endpoint to always returnresolved: [], which meant the apply dialog never appeared when changing token sets.Missing
.nldesign-dialog-overlayCSS — Both the apply dialog and theming-sync dialog were inserted intodocument.bodywith no CSS for.nldesign-dialog-overlay, rendering them inline in the document flow below the viewport rather than as a fixed-position modal. Addedposition: fixed; inset: 0; z-index: 10000overlay CSS andposition: sticky; bottom: 0for the actions row.Test plan
http://localhost:8080python3 check_e2e_coverage.py --mode report→uncovered: 0