This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: comment out unresolved Style-Dictionary token placeholders (M2+L4)#136
Merged
Conversation
…les (M2+L4)
7 municipality token CSS files had unresolved Style-Dictionary reference tokens
(e.g. {dinkelland.color.primary}) that were synced verbatim from upstream but
never post-processed — these produce invalid CSS declarations that browsers
silently discard. Commenting them out makes the intent explicit and prevents
the CSS sanitizer (M1) from rejecting them if read back through the editor.
Files fixed: dinkelland, epe, leiden, noaberkracht, noordwijk, tubbergen, xxllnc.
Total: 29 placeholder lines commented out across 7 files.
L4: noaberkracht.css and token-sets.json both reference legacy #4376fc
(retired Conduction cobalt, 2026-05-13). Added TODO comments flagging the
need for upstream municipality verification before changing the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{dinkelland.color.primary}) that were synced verbatim but never post-processed into actual CSS values. Browsers silently discard these declarations. All 29 affected lines acrossdinkelland,epe,leiden,noaberkracht,noordwijk,tubbergen,xxllncare now commented out withTODO: unresolved Style-Dictionary refmarkers so the next sync can resolve them properly.noaberkracht.cssandtoken-sets.jsonreference#4376fc(legacy Conduction cobalt, retired 2026-05-13). Added TODO comments flagging upstream municipality verification needed before updating the value.Test plan
composer check:strictpasses