Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.
This repository was archived by the owner on May 29, 2026. It is now read-only.

[MEDIUM] M2: Inconsistent admin-bypass auditing — ApplicationVersionsController omits OR audit-trail entry #162

Description

@rubenvdlinde

Severity: MEDIUM

Location: lib/Controller/ApplicationVersionsController.php:524-530 vs lib/Controller/ApplicationsController.php:726-767

Description:
NC-admin bypass is audited inconsistently across controllers:

  • ApplicationsController calls recordAdminBypass(...), which writes into OR's per-object audit trail AND PSR log — bypass events appear in the permission-history panel (REQ-OBRBAC-006).
  • ApplicationVersionsController::requireRole only writes a PSR log entry on bypass. The same NC-admin opening a non-production version under admin bypass leaves no per-application audit-trail record. The permission-history panel loses fidelity for version-level operations.

Suggested fix:

  • Centralise admin-bypass auditing in a shared service (e.g., AuditService::recordAdminBypass) called by both controllers and the MCP dispatcher.
  • Ensure every bypass writes to the OR per-object audit trail, not just PSR log.

Source: deep team-reviewer pass 2026-05-27

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions