Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

retrofit: annotate openregister Bucket 1 (395 methods / 92 REQs / 98 files)#1337

Merged
WilcoLouwerse merged 7 commits into
developmentfrom
retrofit/annotate-openregister-2026-04-23
Apr 28, 2026
Merged

retrofit: annotate openregister Bucket 1 (395 methods / 92 REQs / 98 files)#1337
WilcoLouwerse merged 7 commits into
developmentfrom
retrofit/annotate-openregister-2026-04-23

Conversation

@WilcoLouwerse

@WilcoLouwerse WilcoLouwerse commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Retrofit — Annotation Only

Applies @spec openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md#task-N tags per ADR-003 §Spec traceability.

Ghost change: openspec/archive/retrofit-annotate-openregister-2026-04-23/ (empty spec delta, 92 tasks, all [x] as retroactive).

What this PR does

  • Creates ghost change with 92 tasks — one per REQ that had Bucket 1 matches
  • Adds 395 method-level @spec tags across 98 files (74 PHP + 24 frontend)
  • Adds file-docblock @spec tags where missing (21 frontend files got new top-of-file JSDoc blocks)
  • Adds both annotation commits to .git-blame-ignore-revs
  • Archives the ghost change

What this PR does NOT do

  • No logic changes
  • No formatting / whitespace / reordering
  • No Bucket 2 (see follow-up /opsx-reverse-spec PRs)
  • No Bucket 3/4 (separate follow-ups)
  • 254 NEEDS-REVIEW entries (Bucket 1 @ 0.70–0.85 confidence) deferred — they need human eyes before annotating

Verification

  • composer phpcs passes (0 errors across 71 files)
  • npm run lint passes (0 errors, 218 warnings — all from eslint-plugin-jsdoc not knowing the custom @spec tag; config-level follow-up)
  • 98/98 plan files have the expected @spec tag (grep-verified)
  • .git-blame-ignore-revs includes both annotation commits (197da46 + 5e0d5a8)

Capabilities covered

21 capabilities — top 5 by method count: audit-trail-immutable (117), workflow-engine-abstraction (37), faceting-configuration (35), zoeken-filteren (27), archival-destruction-workflow (23).

Enabling blame-ignore locally

git config blame.ignoreRevsFile .git-blame-ignore-revs

Per-developer choice (not auto-applied).

Source

  • Coverage report: openspec/coverage-report.md generated 2026-04-23
  • Bucket 1 high-confidence only (395 of 649 — 254 NEEDS-REVIEW skipped)

Test plan

  • Verify composer phpcs passes in CI
  • Verify npm run lint passes in CI
  • Spot-check 5–10 Bucket 1 annotations per capability for correctness
  • Confirm retrofit-annotate archive structure matches existing archive conventions

🤖 Generated with Claude Code

WilcoLouwerse and others added 7 commits April 23, 2026 18:05
Generated by opsx-coverage-scan v1 on 2026-04-23. The change proposal
captures Bucket 1 high-confidence REQ matches (395 methods across 98
files) for retroactive @SPEC annotation on retrofit/annotate-openregister-2026-04-23.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds @SPEC PHPDoc tags across 65 lib/ files, pointing methods at their
matching REQs via openspec/changes/retrofit-annotate-openregister-2026-04-23/tasks.md.
Pure annotation change — no logic modifications.

Source: Bucket 1 high-confidence matches from opsx-coverage-scan v1
(2026-04-23). NEEDS-REVIEW entries deferred for human triage.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Completes the annotation pass started in 197da46. Adds @SPEC tags on
8 PHP files under lib/Service and lib/WorkflowEngine + 24 frontend
files under src/. No logic changes.

Source: openspec/coverage-report.md generated 2026-04-23.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contains both annotation commits (197da46 + 5e0d5a8). Developers enable
per-clone with: git config blame.ignoreRevsFile .git-blame-ignore-revs

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The initial file landed with a placeholder hash for 197da46. Real SHA:
197da46fc6e1f8a... (full in file). No behavior change — just makes the
blame-ignore file actually work.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The ghost change is complete (all 92 tasks marked [x] as retroactive
annotations). Move to openspec/archive/ to match OpenSpec workflow.
No spec deltas — no capability specs modified.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 7097e8d

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 147/147
npm ✅ 599/599
PHPUnit
Newman
Playwright ⏭️

Quality workflow — 2026-04-24 05:24 UTC

Download the full PDF report from the workflow artifacts.

@rjzondervan rjzondervan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but to prevent it from intervering with the active review on dev -> beta, wait with merging until that is done.

@WilcoLouwerse WilcoLouwerse merged commit bdd0d6a into development Apr 28, 2026
35 of 41 checks passed
@WilcoLouwerse WilcoLouwerse deleted the retrofit/annotate-openregister-2026-04-23 branch April 28, 2026 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants