This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: reverse-spec approval-workflow (5 REQs / 13 methods)#1400
Merged
WilcoLouwerse merged 5 commits intoMay 4, 2026
Merged
Conversation
Ghost change: retrofit-approval-workflow-2026-05-01 (5 REQs) - REQ-001: Approval chain CRUD - REQ-002: Track object progress through an approval chain - REQ-003: List and filter approval steps - REQ-004: Initialize approval chain steps for an object - REQ-005: Approve or reject a pending step with role enforcement Annotated: ApprovalController (9 methods) + ApprovalService (4 methods) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merges delta into openspec/specs/approval-workflow/spec.md. Creates symlink at openspec/changes/retrofit-approval-workflow-2026-05-01 → archive/2026-05-01-retrofit-approval-workflow-2026-05-01/ to preserve existing @SPEC tag paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 1, 2026
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 147/147 | |||
| npm | ✅ | ✅ 598/598 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-01 19:41 UTC
Download the full PDF report from the workflow artifacts.
remko48
previously approved these changes
May 4, 2026
bbrands02
previously approved these changes
May 4, 2026
…se-spec-openregister-approval-workflow-2026-05-01 # Conflicts: # .git-blame-ignore-revs
WilcoLouwerse
requested review from
Rem-Dam,
SudoThijn,
rjzondervan and
rubenvdlinde
as code owners
remko48
previously approved these changes
May 4, 2026
…se-spec-openregister-approval-workflow-2026-05-01 # Conflicts: # .git-blame-ignore-revs
remko48
approved these changes
May 4, 2026
WilcoLouwerse
deleted the
retrofit/reverse-spec-openregister-approval-workflow-2026-05-01
branch
WilcoLouwerse
added a commit
that referenced
this pull request
May 4, 2026
…+ add .opsx-ignore Aligns the retrofit naming convention with the standard OpenSpec date-prefix convention used by non-retrofit changes (e.g. 2026-03-25-contacts-actions/). Date now appears right after `retrofit-`, so retrofit and non-retrofit changes sort chronologically together when the archive is listed. **Folder renames (13 folders):** - retrofit-actions-2026-05-01 -> retrofit-2026-05-01-actions - retrofit-annotate-openregister-2026-04-23 -> retrofit-2026-04-23-annotate-openregister - retrofit-annotate-openregister-2026-04-30 -> retrofit-2026-04-30-annotate-openregister - retrofit-archival-destruction-workflow-2026-04-24 -> retrofit-2026-04-24-archival-destruction-workflow - retrofit-b2b-crossrefs-2026-04-28 -> retrofit-2026-04-28-b2b-crossrefs - retrofit-calendar-integration-2026-04-28 -> retrofit-2026-04-28-calendar-integration - retrofit-chat-ai-2026-04-30 -> retrofit-2026-04-30-chat-ai - retrofit-content-versioning-2026-04-28 -> retrofit-2026-04-28-content-versioning - retrofit-notificatie-engine-2026-04-28 -> retrofit-2026-04-28-notificatie-engine - retrofit-object-lifecycle-2026-04-28 -> retrofit-2026-04-28-object-lifecycle - retrofit-schema-hooks-2026-04-28 -> retrofit-2026-04-28-schema-hooks - retrofit-tenant-isolation-audit-2026-04-28 -> retrofit-2026-04-28-tenant-isolation-audit - retrofit-tenant-lifecycle-2026-04-28 -> retrofit-2026-04-28-tenant-lifecycle **Path-string updates:** ~298 PHP/JS/MD/YAML files updated. The `@spec openspec/changes/retrofit-...` annotations and internal proposal/design/tasks references all now point at the new folder names. Note `@spec` is a textual reference per the playbook (not a live lookup), so this update keeps the textual paths consistent with where the change actually lives on disk. **New: openregister/.opsx-ignore** Suppresses the two faceting-demo files (NewFacetingExample, ObjectServiceFacetExample) from coverage-scan buckets. These are documentation aids, not canonical implementations. PRs #1397 (oas-generation) and #1400 (approval-workflow) still use the OLD naming on their branches — when those merge, follow-up cleanup is needed (rename the date-prefix to date-after-retrofit, drop their symlinks). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WilcoLouwerse
added a commit
that referenced
this pull request
May 4, 2026
…Tier-2 PRs Cleanup pass for the two retrofit ghost changes that came in via PR #1397 (oas-generation) and PR #1400 (approval-workflow). Both used the 2026-05-01-retrofit-X-2026-05-01 naming with a parallel symlink from openspec/changes/. - Rename 2026-05-01-retrofit-approval-workflow-2026-05-01 -> retrofit-2026-05-01-approval-workflow - Rename 2026-05-01-retrofit-oas-generation-2026-05-01 -> retrofit-2026-05-01-oas-generation - Drop openspec/changes/retrofit-approval-workflow-2026-05-01 symlink - Drop openspec/changes/retrofit-oas-generation-2026-05-01 symlink - Update @SPEC annotations + internal refs to point at the renamed folders Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec
Describes observed behavior of 13 methods under
approval-workflowas 5 new REQs.Ghost change:
retrofit-approval-workflow-2026-05-01(archived).What this PR does
retrofit: true(new capability spec)openspec/specs/approval-workflow/spec.md(new capability)@spectags acrossApprovalControllerandApprovalService@specpath resolution).git-blame-ignore-revswith annotation commit SHAWhat this PR does NOT do
statusOnApprove/statusOnRejectfields that exist in chain definitions but are not acted on by the controller (flagged in spec notes)Review focus
Source:
openspec/coverage-report.mdgenerated 2026-05-01 | Cluster:approval-workflow