This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(FilesController): normalize 'file' field uploads in filesMultipart#1436
Merged
Conversation
POST /api/objects/{register}/{schema}/{id}/filesMultipart with a single
file in the 'file' field returned 500 because extractUploadedFiles()
appended the raw $_FILES entry to the upload list without running it
through normalizeSingleFile. processUploadedFiles then dereferenced
$file['share'] which was missing, causing:
TypeError: FileService::addFile(): Argument #4 ($share) must be of
type bool, null given
Run the 'file' branch through normalizeSingleFile, the same path the
'files[]' branch already uses. Both upload patterns now succeed.
Verified end-to-end against a Woo register import on the dev environment
while writing the new academy tutorial on bestand uploads.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
22 tasks
WilcoLouwerse
suggested changes
May 7, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
Contributor
There was a problem hiding this comment.
Strict-mode review: no 🔴 blockers, but two 🟡 concerns trigger REQUEST_CHANGES — the share field still only matches the literal string 'true', so the commit message's claim that 'share' and 'tags' are populated is only half-true; and no PHPUnit regression test guards the bug-fix path. The Newman CI failure is pre-existing (verified on development HEAD) and not caused by this PR. The core extractUploadedFiles change is correct.
Address PR #1436 review feedback: - Replace `$data['share'] === 'true'` strict comparison with `$this->parseBool(value: $data['share'] ?? false)` in both `normalizeSingleFile` and `normalizeMultipleFiles`. This matches what `create()` already does and accepts `1`, `yes`, `on`, and a real boolean `true` instead of silently returning false for any non-`'true'` literal. - Strengthen `testExtractUploadedFilesSingleFile` to assert the normalized shape (`share` is bool, `tags` is array) so a future refactor of `normalizeSingleFile` cannot silently re-introduce the original `TypeError: FileService::addFile(): Argument #4 ($share) must be of type bool, null given`. - Add `testExtractUploadedFilesShareParsing` data provider covering the truthy/falsy cases parseBool now accepts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WilcoLouwerse
approved these changes
May 7, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
Contributor
There was a problem hiding this comment.
Both prior 🟡 concerns resolved in 2166e03 — parseBool used in both normalizers and regression test asserts the normalized shape plus a parseBool data provider. CI green (Newman), no new findings.
rjzondervan
approved these changes
May 7, 2026
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 147/147 | |||
| npm | ✅ | ✅ 598/598 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-07 11:51 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
Surfaced while writing the new Conduction Academy tutorial on uploading files to a Woo publication. The tutorial walks through four upload modes; this was the only one that returned a 500.
Test plan