This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(npm): regenerate package-lock.json after nc-vue major bump#1537
Merged
rubenvdlinde merged 1 commit intoMay 18, 2026
Merged
Conversation
The lockfile was out of sync with package.json after the @conduction/nextcloud-vue major bump (0.1.0-beta.17 → 1.0.0-beta.46) plus 5 deps missing from the lockfile entirely (@microsoft/fetch-event-source, @nextcloud/notify_push, leaflet, leaflet.markercluster, marked). `npm ci` was failing on every PR with "lock file's @conduction/nextcloud-vue@0.1.0-beta.17 does not satisfy @conduction/nextcloud-vue@1.0.0-beta.46", breaking License/npm, Security/npm, Vue/eslint, and Vue/stylelint CI checks across the board. Regenerated via `npm install` on Node 20. Diff is large (+5609 / -207) because the missing transitive entries (webpack toolchain, sass, stylelint configs, eslint resolvers, leaflet, crypto-browserify shims) all need to land. Direct-dep version bumps (incidental): csstype 3.1.3 → 3.2.3, get-tsconfig 4.7.6 → 4.14.0. No removed deps.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 155/155 | |||
| npm | ✅ | ✅ 602/602 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-18 15:00 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.jsonwas out of sync withpackage.jsonondevelopment, causingnpm cito fail on every PR with:This broke License/npm, Security/npm, Vue/eslint, Vue/stylelint across every open PR.
What changed
npm installon Node 20 / npm 11package-lock.jsononly — nopackage.jsonchangeDiff shape
The size looks scary but the analysis is benign:
csstype3.1.3 → 3.2.3,get-tsconfig4.7.6 → 4.14.0 (both minor)@conduction/nextcloud-vue@1.0.0-beta.46,marked@16.4.0,@microsoft/fetch-event-source@2.0.1,@nextcloud/notify_push@1.4.0,leaflet@1.9.4,leaflet.markercluster@1.5.3Verified
npm ci --dry-runreports "up to date in 6s" against this lockfilepackage.jsonchangeWhy it grew so much
The old lockfile was generated against a much older
package.jsonand the diff incorporated the major nc-vue bump from beta.17 → beta.46 (which itself pulled in webpack/sass/stylelint config bumps via peer chains). Everything new is a transitive consequence of declaredpackage.jsonversions — nothing was added by hand.Test plan
enginemismatch fatals (only EBADENGINE warnings, which are pre-existing)Out of scope
development— separate upstream issuephpcsfailure onlib/Settings/IntegrationsAdminSettings.php+lib/Capabilities/IntegrationsCapability.php— separate upstream issue