Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

fix(npm): regenerate package-lock.json after nc-vue major bump#1537

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/regenerate-package-lock-after-nc-vue-bump
May 18, 2026
Merged

fix(npm): regenerate package-lock.json after nc-vue major bump#1537
rubenvdlinde merged 1 commit into
developmentfrom
fix/regenerate-package-lock-after-nc-vue-bump

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

package-lock.json was out of sync with package.json on development, causing npm ci to fail on every PR with:

Invalid: lock file's @conduction/nextcloud-vue@0.1.0-beta.17 does not satisfy @conduction/nextcloud-vue@1.0.0-beta.46
Missing: @microsoft/fetch-event-source@2.0.1, @nextcloud/notify_push@1.4.0,
         leaflet@1.9.4, leaflet.markercluster@1.5.3, marked@15.0.12 from lock file

This broke License/npm, Security/npm, Vue/eslint, Vue/stylelint across every open PR.

What changed

  • Regenerated via npm install on Node 20 / npm 11
  • package-lock.json only — no package.json change

Diff shape

package-lock.json | 5816 +++++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 5609 insertions(+), 207 deletions(-)

The size looks scary but the analysis is benign:

Category Count Notes
Root-level deps changed 2 csstype 3.1.3 → 3.2.3, get-tsconfig 4.7.6 → 4.14.0 (both minor)
Root-level deps removed 0
New transitive entries 379 webpack toolchain, sass, stylelint configs, eslint resolvers, leaflet, crypto-browserify shims — all transitives that were missing
Previously-missing direct deps now present 6 @conduction/nextcloud-vue@1.0.0-beta.46, marked@16.4.0, @microsoft/fetch-event-source@2.0.1, @nextcloud/notify_push@1.4.0, leaflet@1.9.4, leaflet.markercluster@1.5.3

Verified

  • npm ci --dry-run reports "up to date in 6s" against this lockfile
  • ✅ All 5 packages Wilco called out as missing are now present
  • ✅ No package.json change

Why it grew so much

The old lockfile was generated against a much older package.json and the diff incorporated the major nc-vue bump from beta.17 → beta.46 (which itself pulled in webpack/sass/stylelint config bumps via peer chains). Everything new is a transitive consequence of declared package.json versions — nothing was added by hand.

Test plan

  • CI: License/npm, Security/npm, Vue/eslint, Vue/stylelint go from red → green on this PR
  • After merge: every open PR rebased on top should see the same 4 CI checks turn green
  • No engine mismatch fatals (only EBADENGINE warnings, which are pre-existing)

Out of scope

  • Newman API Test Suite is also red on development — separate upstream issue
  • phpcs failure on lib/Settings/IntegrationsAdminSettings.php + lib/Capabilities/IntegrationsCapability.php — separate upstream issue

The lockfile was out of sync with package.json after the
@conduction/nextcloud-vue major bump (0.1.0-beta.17 → 1.0.0-beta.46)
plus 5 deps missing from the lockfile entirely (@microsoft/fetch-event-source,
@nextcloud/notify_push, leaflet, leaflet.markercluster, marked).

`npm ci` was failing on every PR with "lock file's
@conduction/nextcloud-vue@0.1.0-beta.17 does not satisfy
@conduction/nextcloud-vue@1.0.0-beta.46", breaking License/npm,
Security/npm, Vue/eslint, and Vue/stylelint CI checks across the board.

Regenerated via `npm install` on Node 20. Diff is large (+5609 / -207)
because the missing transitive entries (webpack toolchain, sass, stylelint
configs, eslint resolvers, leaflet, crypto-browserify shims) all need to land.

Direct-dep version bumps (incidental): csstype 3.1.3 → 3.2.3,
get-tsconfig 4.7.6 → 4.14.0. No removed deps.
@rubenvdlinde rubenvdlinde merged commit 512602b into development May 18, 2026
11 of 14 checks passed
@rubenvdlinde rubenvdlinde deleted the fix/regenerate-package-lock-after-nc-vue-bump branch May 18, 2026 14:58
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 90321ec

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 155/155
npm ✅ 602/602
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-05-18 15:00 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant