fix(integrations): pass Tier-2 constructor args in calendar/email/tasks DI factories + log provider boot failures

[rubenvdlinde]

Summary

A live-NC E2E surfaced that three integration providers — calendar, email, tasks — were missing in production. Their OCS registry tabs 404'd and the registered-provider count was 22 instead of 25.

Root cause

The DI factory closures in Application::registerBuiltinIntegrationProviders() were not updated when these providers gained Tier-2 constructor args:

Provider	Tier-2 arg(s) the factory failed to pass
CalendarProvider	$calendarLinkService
EmailProvider	$emailLinkService
TasksProvider	$registerMapper, $schemaMapper, $objectService

The closures still passed the old arg lists, so each provider threw ArgumentCountError on construction. bootBuiltinIntegrationProviders()'s try/catch silently swallowed the Throwable, dropping the three providers from the IntegrationRegistry. Existing tests instantiate providers directly with mocks, so they were blind to the factory-wiring bug — only the live E2E caught it.

Changes

• The 3 factory fixes — resolve and pass the Tier-2 dependencies, matching the already-correct contacts/deck/forms factories.
• Harden the swallow — bootBuiltinIntegrationProviders() now logs a warning (provider class + exception message) when a provider fails to construct, so a mis-wired factory is diagnosable in the logs instead of a silently-missing tab. Graceful degradation is preserved (boot does not crash on one bad provider).
• Label consistency (cosmetic) — align the maps/time-tracker OCS labels (Location/Time) with the in-page registry pills from the nc-vue descriptors (Locations/Time tracker). OR getLabel() is the smaller change, so no nc-vue PR is needed.
• Regression test — BuiltinProviderDiFactoryTest invokes the actual factory closures (via a captured IRegistrationContext + a mocking container) and asserts every provider constructs without throwing. This closes the direct-instantiation blind spot. It fails on the pre-fix code (3 ArgumentCountErrors for calendar/email/tasks).

Verification

• php -l clean on all 4 touched files.
• Resolved all 15 explicit-closure providers through the real NC DI container: 0 failures with the fix; reverting to origin/development produces exactly 3 ArgumentCountErrors (Calendar [Changelog CI] Add Changelog for Version 0.1.2 #2 $calendarLinkService, Email [Changelog CI] Add Changelog for Version 0.1.2 #2 $emailLinkService, Tasks [Changelog CI] Add Changelog for Version 0.1.2 #2 $registerMapper).
• Live OCS capabilities after deploy + apache2ctl graceful: integrations.registered length 25, now including tasks, calendar, email.

Note: PHPCS/PHPUnit could not be run in the local dev container due to a pre-existing incomplete bind-mount vendor/ (missing sabre/uri, unrelated to this change). CI runs both in a clean-vendor container.

Refs ADR-019, ADR-022.

Test plan

• CI: PHPUnit (incl. new BuiltinProviderDiFactoryTest) + PHPCS/PHPMD/Psalm/PHPStan green
• OCS capabilities.openregister.integrations.registered length is 25 incl. calendar/email/tasks
• Calendar/email/tasks tabs render in the registry sidebar
• maps/time-tracker pill labels match OCS labels

[github-actions]

Quality Report — ConductionNL/openregister @ b67864f

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	❌
phpmd	✅
psalm	✅
phpstan	✅
phpmetrics	✅
eslint		❌
stylelint		❌
composer			✅	✅ 165/165
npm			✅	✅ 532/532
PHPUnit					⏭️
Newman					⏭️
Playwright					⏭️

---

Quality workflow — 2026-05-25 09:45 UTC

Download the full PDF report from the workflow artifacts.