This repository was archived by the owner on May 29, 2026. It is now read-only.
[Changelog CI] Add Changelog for Version 0.1.19#37
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
rubenvdlinde
added a commit
that referenced
this pull request
Apr 23, 2026
…r mock Test fixes to match production constructor signatures that had drifted: - **\`ObjectService\`**: arg #37 is \`DateTimeNormalizer\`, not \`IAppContainer\`. ObjectServiceTest, ObjectServiceDeepTest, and ObjectServiceRefactoredMethodsTest now pass a DateTimeNormalizer mock before the container. ObjectServiceTest / DeepTest also stub \`DateTimeNormalizer::normalize()\` with a DateTimeImmutable factory so normalizeDateValues tests actually exercise the conversion instead of short-circuiting on a null-returning mock. - **\`ReferentialIntegrityService\`**: gained a 6th \`IDBConnection\` parameter. Three test files (Test, CoverageTest, Object/BranchTest) now pass \`IDBConnection::class\` mocks. - **\`UserService\`**: gained \`IDBConnection\` + \`L10N\\IFactory\` as args 12 and 13. Three test files (UserServiceProfileActionsTest, CoverageTest, BranchCoverageTest) updated. - **\`MagicMapper\`**: resolves DateTimeNormalizer lazily from the container inside its constructor to build MagicBulkHandler. The test's plain ContainerInterface mock returned null → MagicBulkHandler rejected null for its typed \`\$dateTimeNormalizer\`. MagicMapperTest now hands back a DateTimeNormalizer mock from the container's \`get()\` callback. - **\`TextExtractionServiceDeepTest::testExtractObjectDeletedObject\`**: moved \`logger->expects(atLeastOnce())->method('info')\` before the triggering call. PHPUnit's \`expects()\` does not retroactively match invocations that occurred before the expectation was set, so the assertion was silently unmet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version: 0.1.19