This repository was archived by the owner on May 29, 2026. It is now read-only.
chore: kanban app icons, remove stale test-results, coverage report#246
Merged
Conversation
- Extend base webpack config instead of replacing resolve/module - Add NodePolyfillPlugin for process polyfill compatibility - Add CnObjectSidebar + objectSidebarState for proper sidebar positioning - Follows ADR-017 (component composition) and ADR-018 (header actions)
Settings link in gear foldout now opens NcAppSettingsDialog modal
instead of routing to /settings page. Matches ADR-004 pattern:
- Admin config: /settings/admin/{appid} (NC admin panel)
- In-app settings: NcAppSettingsDialog modal from gear menu
- Fix bare t() to this.t() in Settings.vue methods - Add 21 missing keys to en.json and nl.json (108→129 keys)
- "Default Project Configuration" → "Default project configuration" - "Register Setup" → "Register setup" - "Version Information" → "Version information"
…omplete-translations # Conflicts: # test-results/README.md # test-results/accessibility-results.md # test-results/api-results.md # test-results/performance-results.md # test-results/security-results.md # test-results/ux-results.md
Contributor
Quality Report — ConductionNL/planix @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 404/404 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-26 05:01 UTC
Download the full PDF report from the workflow artifacts.
- Add eslint-plugin-import-x and node-polyfill-webpack-plugin overrides/pins so the lockfile resolves without --legacy-peer-deps (lint-check ran 'npm ci' which failed on pre-existing peer-dependency conflicts). - Regenerate package-lock.json under strict peer resolution. - Declare the ADR-008 @SPEC JSDoc tag in eslint.config.js so the spec-coverage annotations stop tripping jsdoc/check-tag-names. - Add missing @param JSDoc lines and fix stylelint rule-empty-line-before errors in Settings.vue surfaced by the development merge.
Contributor
Quality Report — ConductionNL/planix @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 426/426 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-26 05:20 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidation of pending work (fleet sweep 2026-05-26). Commits already on
feature/i18n-complete-translations.🤖 Generated with Claude Code