This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(security): cross-tenant IDOR — authorization blocks + owner field#276
Merged
rubenvdlinde merged 1 commit intoMay 27, 2026
Merged
Conversation
…ross-tenant IDOR Fixes #257 (IDOR: any authenticated user could read/write all projects/tasks), #258 (missing owner field blocked creator-based RBAC), and #259 (migration docblock claimed publicWrite:true contradicting the membership-access spec). Changes: - planix_register.json: add `authorization` blocks to project, task, column, and timeEntry schemas enforcing member-based row-level read/write filtering; project delete restricted to owner or admin; timeEntry write restricted to the logging user. Add explicit `publicRead: false` and `publicWrite: false` to the register block. Add `owner` field to project schema for creator RBAC. Bump register version 0.2.0 -> 0.2.1, info version -> 0.2.3. - Version20260403000000.php: correct misleading docblock that claimed publicWrite:true — the intent is and has always been publicWrite:false. - tests/unit/Settings/PlanixRegisterSchemaTest.php: 7 new tests that mechanically assert the security properties introduced above, acting as regression guards so the IDOR cannot silently reopen.
This was referenced May 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authorizationblocks to all four data schemas (project,task,column,timeEntry) inplanix_register.json. Projects are now readable/writable only by members; non-members get filtered out at the OR row-level. Task/column visibility is chained via a project-member lookup. Time entries are restricted to the logging user for write operations.owner(string) field to the project schema. The projectdeleteauthorization rule uses{ "match": { "owner": "$userId" } }so only the creator or an admin can delete a project.Version20260403000000.phpdocblock incorrectly claimedpublicWrite: true/publicRead: true. Corrected to match the actual intent (false/false). The register block inplanix_register.jsonnow carries explicit"publicRead": false, "publicWrite": falseso OR never falls back to an ambiguous default.What changed
lib/Settings/planix_register.jsonauthorizationon project/task/column/timeEntry;ownerfield on project;publicRead/Write: falseon register; register version 0.2.0 → 0.2.1; info version → 0.2.3lib/Migration/Version20260403000000.phppublicWrite: trueclaimtests/unit/Settings/PlanixRegisterSchemaTest.phpTest plan
PlanixRegisterSchemaTestpass (phpunit --configuration phpunit-unit.xml)python3 -m json.tool planix_register.jsonCloses #257
Closes #258
Closes #259