This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: dialog/store correctness — probe-removal, race, owner gate (#260 #261 #262 #264)#277
Merged
Merged
Conversation
- #260 ProjectLeaveDialog.mounted() no longer calls leaveProject as a probe; it inspects the already-fetched members array via fetchProject so Cancel can never inadvertently mutate state. - #261/#262 Split removeMember into a pure write action and a new getMemberTaskCount read action. confirmRemoveMember now queries the count first and only removes when count is zero, eliminating the remove-then-re-add race and the silent data-loss if the re-add fails. - #264 ProjectDeleteDialog now checks project.owner === currentUid || isAdmin before enabling the delete button. The canDelete guard is also enforced in confirm() as a server-side safety net. owner is now set on createProject so newly created projects are always gated correctly.
This was referenced May 27, 2026
[LOW] Documentation link points to conduction.nl marketing site instead of planix.conduction.nl
#271
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mounted()no longer callsleaveProjectas a probe. It fetches the project and inspects the members array client-side — Cancel can no longer mutate server state.removeMemberis now a pure write action. A newgetMemberTaskCountread action handles the count query.confirmRemoveMembercalls the read action first and only removes when count is zero, eliminating the remove-then-re-add race and silent data loss if re-add fails.canDeletecomputed (owner === currentUid || isAdmin) that gates the delete button and confirm() server-side guard.createProjectnow sets theownerfield so newly created projects are always gated correctly.Test plan