This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: use force:false in repair step to prevent overwriting operator schema customisations#281
Merged
Merged
Conversation
…chema customisations The repair step's loadConfiguration(force:true) caused seed data to be re-imported on every Nextcloud upgrade, silently overwriting operator- customised schema fields, properties, and permissions. force:true is intentional only on SettingsController::load() (manual admin reset). The repair step should seed only when not yet imported. Source: nextcloud-app-template C1 propagation sweep 2026-05-27
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
loadConfiguration(force: true)anti-pattern in the Nextcloud repair step that was inherited from the app template scaffold.lib/Repair/InitializeSettings.phpfromforce: truetoforce: falseSettingsController::load()onforce: true(intentional admin reset button)Why
force: truecaused the seed register to be re-imported on every Nextcloud upgrade, silently overwriting any operator-customised schema fields, properties, and permissions.force: falseseeds only when not yet imported — the correct behaviour for an automatic repair step.Closes #280
References