This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(security): schema RBAC — project update owner-only + cross-project create guards#282
Merged
Merged
Conversation
…add cross-project guards (C1 + H1) C1: project.update now requires owner match instead of member match. Any member could previously update owner/members fields, allowing a non-owner to evict the project owner. Now only the owner (or admin) may update a project. H1: task.create and column.create add parent-project membership predicate, preventing cross-project injection by an authenticated user who is not a member of the target project. timeEntry.create adds user:$userId match to prevent impersonation — a user may only log time as themselves. Bumps all affected schema versions (0.1.1 → 0.1.2) and register/ info.xml version (0.2.3 → 0.2.4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
planix_register.json—project.updatenow requiresowner: $userIdmatch. Previously any project member could updateowner/membersfields, allowing non-owners to evict the owner. Now only the owner (or admin) may update the project.planix_register.json—task.createandcolumn.createnow require the caller to be a member of the target project (parent-project lookup predicate), closing cross-project injection.timeEntry.createaddsuser: $userIdmatch to prevent impersonation — users may only log time as themselves.task,column,timeEntry,project; register/info.xml bumped 0.2.3 → 0.2.4.Test plan
python3 -c "import json; json.load(open('lib/Settings/planix_register.json'))"— passes