This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: pass composer check:strict — named-arg PHPCS + orphan-auth gate-6#288
Merged
Conversation
SettingsService:220 — add named parameter `raw:` to internal call of validateDefaultColumns() to satisfy the NamedParameters PHPCS sniff. ProjectController::create() — delegate the allow_project_creation policy check to checkCreatePolicy() instead of duplicating it inline. This removes the duplicated guard, gives checkCreatePolicy() a PHP caller so gate-6 orphan-auth passes, and consolidates the 403 path in one place. composer check:strict: exit 0. All 19 Hydra gates GREEN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raw:to the internalvalidateDefaultColumns()call to satisfy theNamedParametersPHPCS sniff (was the only remaining PHPCS error)allow_project_creationpolicy check tocheckCreatePolicy()instead of duplicating the guard inline; this givescheckCreatePolicya PHP caller so Hydra gate-6 orphan-auth passes, and consolidates the 403 path in one placeResults
composer check:strict: exit 0 (ALL CHECKS PASSED)@specwarnings remain — cosmetic, as expected)Test plan
composer check:strictexits 0 on the branchbash scripts/run-hydra-gates.sh→ all 19 PASScheckCreatePolicystill reachable viaGET /api/projects/check-create-policycreate()returns 403 whenallow_project_creationis restricted (delegates tocheckCreatePolicy())