This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(zaaktype-configuratie): apply spec (no-op — already implemented)#333
Merged
Merged
Conversation
…on development) Records the apply phase for the zaaktype-configuratie change. All 4 V1 tasks (DurationPicker.vue, GeneralTab DurationPicker integration, active case count warning in CaseTypeDetail, publish validation with Dutch error messages in caseTypeValidation.js) are already implemented on development via earlier commits (notably 5497d07). Spec marked status: implemented. PHP php -l clean, JSON jq valid. Strict composer gates and i18n deferred per fleet-wide pattern. V2 requirements (REQ-ZTC-07..10) and remaining V1 admin UIs (REQ-ZTC-03..06) deferred to future changes. Refs openspec/changes/zaaktype-configuratie/.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 407/407 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 613 specs)
Quality workflow — 2026-05-11 07:31 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the apply phase for the
zaaktype-configuratieopenspec change as a no-op. All four V1 tasks defined intasks.mdare already implemented ondevelopmentvia earlier commits (notably5497d07 feat: Implement zaaktype-configuratie spec — duration picker, active case warnings).src/views/settings/components/DurationPicker.vueexistssrc/views/settings/tabs/GeneralTab.vueintegratesDurationPickerforprocessingDeadline,serviceTarget,extensionPeriodsrc/views/settings/CaseTypeDetail.vueshows the active case count warningsrc/utils/caseTypeValidation.jsexposesvalidateForPublish()with Dutch error messagesSpec is marked
status: implemented. This PR adds the missingbuilds/build.jsonapply marker so the change is tracked in the openspec pipeline.Validation
php -lclean acrosslib/jq -e .valid forprocest_register.jsonand the newbuild.jsoncheck:strictgates and i18n: deferred per fleet-wide patternDeferred (future changes)
V1 admin UIs still missing for document types, property definitions, role types, result types. All V2 features (parafeerroute UI, import/export, versioning, test mode) tracked in the spec's "Not yet implemented" section.
Test plan