This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(wms-wfs-layers): apply spec#401
Merged
Merged
Conversation
Manifest-first WMS/WFS overlay layer subscription per case type: - Add wmsLayer schema (title, type WMS/WFS, url, layerName, srs default EPSG:28992, opacity 0-1, attribution, queryable, format, version, extentCutoffKm default 50, isDefault, active) to procest_register.json - Add layerIds: array<uuid wmsLayer> field to caseType schema - Register wmsLayer slug + wms_layer_schema config key in SettingsService - Add WmsLayers (type: index, admin-only) + WmsLayerDetail (type: detail) manifest pages to src/manifest.json (per ADR-008 manifest-first; no bespoke CRUD controller) — Verbinding testen tab wired to action endpoint - Add Kaartlagen menu entry (settings section, admin permission) - New WmsWfsService — getLayersForCaseType, validateLayer, proxyRequest, getLayerById, buildGetMapUrl, buildGetFeatureUrl; all outbound HTTP delegated to GisProxyService::proxyRequest (allowlist + rate limit enforced upstream); tile cap 512x512, WFS BBOX required, 50km extent cutoff, non-queryable layers reject GetFeatureInfo - New action-only WmsWfsController + GET /api/wms-wfs/proxy route (CRUD on wmsLayer served by OpenRegister auto-routes) Per OPSX strict watchdog: no i18n, no composer check; php -l + jq passed. T04/T05/T06 (frontend Leaflet wiring) deferred — backend exposes the contract the Vue components will consume.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 673 specs)
Quality workflow — 2026-05-11 16:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifest-first apply of
openspec/changes/wms-wfs-layers:wmsLayerschema (title, type WMS/WFS, url, layerName, srs defaultEPSG:28992, opacity 0-1, attribution, queryable, format, version, extentCutoffKm default 50, isDefault, active) inlib/Settings/procest_register.json(REQ-WMS-1)caseType.layerIds: array<uuid wmsLayer>field for per-case-type subscription (REQ-WMS-4)wmsLayerslug +wms_layer_schemaconfig key registered inSettingsService(CONFIG_KEYS + SLUG_TO_CONFIG_KEY)WmsLayers(type: 'index') andWmsLayerDetail(type: 'detail') insrc/manifest.jsonplusWmsLayersMenuentry (admin-only, settings section) — nocomponentkey, no bespoke admin Vue view (REQ-WMS-2 / ADR-008)lib/Service/WmsWfsService.php—getLayersForCaseType(),validateLayer(),proxyRequest(),getLayerById(),buildGetMapUrl(),buildGetFeatureUrl(). All outbound HTTP routed throughGisProxyService::proxyRequest(allowlist + rate limit enforced upstream). Tile cap 512x512, WFS BBOX mandatory, 50 km extent cutoff, non-queryable layers reject GetFeatureInfo (REQ-WMS-3, REQ-WMS-5, REQ-WMS-7, REQ-WMS-8)lib/Controller/WmsWfsController.php+GET /api/wms-wfs/proxyroute — CRUD onwmsLayerserved by OpenRegister's auto-exposed/api/objects/<register>/<schema>endpoints (no bespoke CRUD controller)Strict watchdog
composer checkphp -lclean on all modified/added PHPjq emptyclean onprocest_register.jsonandmanifest.jsonDeferred (frontend follow-up)
T04 (CaseTypeDetail "Kaartlagen" tab), T05 (CaseMap
layerIdsprop + Leaflet integration) and T06 (MapLayerLegend.vue) are deferred to a follow-up PR — the backend exposes the contract the Vue components will consume.Test plan
wmsLayervia/api/objects/procest/wmsLayer→ schema validates, UUID returned, GET round-trips fields/settings/wms-layers→ manifest renders the index page with columns title/type/url/layerName/queryable/active/settings/wms-layers/:id→ detail page withVerbinding testentabGET /api/wms-wfs/proxy?layerId=<uuid>&request=GetCapabilitiesagainst a PDOK-hosted layer returns parsed capabilities; URL outside allowlist returns 403caseType.layerIds = [L1.id]persists across reload and is returned bygetLayersForCaseType()