This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(pdok): route PDOK lookups through openconnector (closes #404)#410
Closed
rubenvdlinde wants to merge 0 commit into
Closed
feat(pdok): route PDOK lookups through openconnector (closes #404)#410rubenvdlinde wants to merge 0 commit into
rubenvdlinde wants to merge 0 commit into
Conversation
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 21:45 UTC
Download the full PDF report from the workflow artifacts.
WilcoLouwerse
suggested changes
May 15, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
There was a problem hiding this comment.
🔴 Blockers
- 🔴 suggest() returns null on 503 — breaks AddressSearch template
- 🔴 PR-2.1 marked done but no JS unit test suite exists
🟡 Concerns
- 🟡 Response envelope shape change is an unverified cross-repo contract
- 🟡 lastWarning is exported but no caller reads it — 404 inline warning is dead code
- 🟡 design.md documents free() with a start parameter that the implementation dropped
🟢 Minor
- 🟢 design.md BASE_URL pseudocode uses hardcoded /index.php/ prefix
rubenvdlinde
force-pushed
the
feature/migrate-pdok-to-openconnector
branch
from
209c64a to
a134a39
Compare
3 tasks
Contributor
Author
|
Auto-closed in error by a force-push bug in the quality-cleanup harness. Reopened as #497 with the same branch and content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements migrate-pdok-to-openconnector — the procest subset of
shared-pdok-via-openconnector.What
src/services/pdokService.jsrewritten as a thin shim: all PDOK access now flows through/index.php/apps/openconnector/api/pdok/*instead of direct browser calls toapi.pdok.nl.src/store/modules/gis.jsandsrc/components/map/AddressSearch.vueunchanged.message_keyfor display; 404 (openconnector absent) → empty result + non-blocking warning; form submission unaffected.Dependencies
Depends on openconnector#752 (PDOK adapter PR). Functional E2E testing (PR-3) and fixture bootstrap (PR-4) deferred until openconnector is installed.
Test plan
api.pdok.nl)Closes #404.