This repository was archived by the owner on May 29, 2026. It is now read-only.
docs(status-engine): per-schema lifecycle migration plan (closes #408)#414
Closed
rubenvdlinde wants to merge 0 commit into
Closed
docs(status-engine): per-schema lifecycle migration plan (closes #408)#414rubenvdlinde wants to merge 0 commit into
rubenvdlinde wants to merge 0 commit into
Conversation
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-11 22:03 UTC
Download the full PDF report from the workflow artifacts.
WilcoLouwerse
suggested changes
May 15, 2026
WilcoLouwerse
left a comment
WilcoLouwerse
left a comment
There was a problem hiding this comment.
🟡 Concerns
- 🟡 Controllers said to call ObjectService::saveObject() directly post-migration, contradicting the stated migration goal
- 🟡 hoorzitting schema listed in scope note but not covered in tasks or spec
🟢 Minor
- 🟢 Proposal scope says 'zaak (AWB bezwaar lifecycle)' but no zaak schema is addressed
rubenvdlinde
force-pushed
the
feature/migrate-status-engine-to-or-lifecycle
branch
from
5ed9348 to
a134a39
Compare
Contributor
Author
|
Auto-closed in error by a force-push bug in the quality-cleanup harness. Reopened as #493 with the same branch and content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adoption-only. No central state-machine service exists to migrate — state lives as scattered STATUS_* constants. Per ADR-031, each stateful schema (voorstel, bezwaar, parafeerroute, hoorzitting) gets its own follow-up PR moving its state machine to x-openregister-lifecycle. Closes #408.