This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(manifest): re-add Voorstellen filter-tabs via config.quickFilters#439
Merged
Merged
Conversation
Restore the Concept / In behandeling / Afgerond filter-tabs the Voorstellen conversion (#429) had to drop — `config.filter` is fixed, not a clickable toggle. nc-vue beta.42 added `config.quickFilters` (a tab strip above the table whose `filter` is merged into the fetch when active) — see nc-vue #226. Tabs (in order, default "Alle"): - Alle — no filter - Concept — `status:"concept"` - In behandeling — `status: ["in_parafering","ter_accordering","geaccordeerd","aangeboden","teruggestuurd"]` - Afgerond — `status: ["besloten","gearchiveerd"]` Status enum values verified against `voorstel` schema in `lib/Settings/procest_register.json`. Also: bump `@conduction/nextcloud-vue` `^1.0.0-beta.40` → `^1.0.0-beta.42` to pick up the `quickFilters` config (and the built-in `date`/`link` cell rendering for future column work). Verified: `node tests/validate-manifest.js` — same pre-existing error set on unrelated pages (Voorstellen is at index 13; no errors there); `npm run build` ✓.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Spec coverage: 7% (30 tests / 456 specs)
Quality workflow — 2026-05-13 06:11 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the Concept / In behandeling / Afgerond filter-tabs the Voorstellen conversion (#429) had to drop —
config.filteris fixed, not a clickable toggle. nc-vue beta.42 (#226) addedconfig.quickFilters(tab strip above the table whosefilteris merged into the fetch when active).Tabs (Alle is default — initial view shows everything):
status:"concept"status: ["in_parafering","ter_accordering","geaccordeerd","aangeboden","teruggestuurd"]status: ["besloten","gearchiveerd"]Status enum values verified against
voorstelschema inlib/Settings/procest_register.json.Also bumps
@conduction/nextcloud-vue^1.0.0-beta.40→^1.0.0-beta.42(the version that shipsquickFilters+ built-indate/linkcell rendering).Verified:
node tests/validate-manifest.js— same pre-existing error set on unrelated pages; Voorstellen (page 13) has no errors.npm run build✓.🤖 Generated with Claude Code