chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#447
chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#447rubenvdlinde wants to merge 0 commit into
Conversation
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Spec coverage: 7% (30 tests / 456 specs)
Quality workflow — 2026-05-13 10:54 UTC
Download the full PDF report from the workflow artifacts.
| @@ -1,6 +1,6 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"> | |||
| <polygon points="256,26 455.19,141 455.19,371 256,486 56.81,371 56.81,141" fill="#4376FC"/> | |||
There was a problem hiding this comment.
🟡 CONCERN: Overlapping edit with PR #446 — merge order matters
Both PR #446 and PR #447 modify img/app-store.svg independently: #446 changes the polygon fill from #4376FC to #21468B, while #447 changes the glyph transform/scale. Because these are parallel edits to the same file with no shared context lines, whichever PR merges second will produce a diff that only carries its own change. If #447 merges after #446, the rebased diff must include the color already applied by #446; otherwise the polygon fill will revert to #4376FC. Verify the branch that #447 is based on already contains the #446 change (or rebase before merging), and confirm the final merged file contains both the #21468B fill AND the translate(164,164) scale(7.67) transform.
010426e to
a134a39
Compare
|
Auto-closed in error by a force-push bug in the quality-cleanup harness. Reopened as #487 with the same branch and content. |
Aligns this app with the design-system 2.10.0 release: preset bumped, hard-coded
<DetailHero/>status/versionprops dropped (the new preset auto-derives fromappinfo/info.xml+ SemVer), inner glyph inimg/app-store.svgshrunk to ~40% of the hex height. No code or behaviour changes beyond the brand chrome.