Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#447

Closed
rubenvdlinde wants to merge 0 commit into
developmentfrom
chore/preset-2.10-derived-status
Closed

chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#447
rubenvdlinde wants to merge 0 commit into
developmentfrom
chore/preset-2.10-derived-status

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Aligns this app with the design-system 2.10.0 release: preset bumped, hard-coded <DetailHero/> status/version props dropped (the new preset auto-derives from appinfo/info.xml + SemVer), inner glyph in img/app-store.svg shrunk to ~40% of the hex height. No code or behaviour changes beyond the brand chrome.

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/procest @ 6e0dd20

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer ✅ 100/100
npm ✅ 420/420
PHPUnit
Newman ⏭️
Playwright

Coverage: 0% (0/81 statements)

Spec coverage: 7% (30 tests / 456 specs)


Quality workflow — 2026-05-13 10:54 UTC

Download the full PDF report from the workflow artifacts.

@WilcoLouwerse WilcoLouwerse left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread img/app-store.svg
@@ -1,6 +1,6 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<polygon points="256,26 455.19,141 455.19,371 256,486 56.81,371 56.81,141" fill="#4376FC"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 CONCERN: Overlapping edit with PR #446 — merge order matters

Both PR #446 and PR #447 modify img/app-store.svg independently: #446 changes the polygon fill from #4376FC to #21468B, while #447 changes the glyph transform/scale. Because these are parallel edits to the same file with no shared context lines, whichever PR merges second will produce a diff that only carries its own change. If #447 merges after #446, the rebased diff must include the color already applied by #446; otherwise the polygon fill will revert to #4376FC. Verify the branch that #447 is based on already contains the #446 change (or rebase before merging), and confirm the final merged file contains both the #21468B fill AND the translate(164,164) scale(7.67) transform.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Auto-closed in error by a force-push bug in the quality-cleanup harness. Reopened as #487 with the same branch and content.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants