This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(procest): dashboard + header/PHPCS/i18n cleanup (re-do of #272)#489
Merged
Merged
Conversation
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
rubenvdlinde
force-pushed
the
fix/dashboard-header-phpcs-i18n
branch
from
d4ca3fd to
30900f4
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 03:33 UTC
Download the full PDF report from the workflow artifacts.
…do of #272) Re-implements the still-relevant parts of #272 against current development (after the json-manifest migration): - Dashboard: remove card-in-card framing (background/border/border-radius) and inner scrollbars from the DeadlineAlerts / StalledCases / TaskDueReminders widgets so they sit cleanly inside the manifest dashboard tiles. - i18n: wrap the "Unknown" fallback labels in dashboardHelpers.js and doorlooptijdHelpers.js with t('procest', ...); add the missing dashboard translation keys (All cases active, No task reminders, SLA Compliance, View all deadline alerts) to l10n/{en,nl}.{js,json} with Dutch translations; drop four malformed extraction-artifact keys ("Case created with type \", "Case type \", "Status changed from/to \") that left l10n/en.js syntactically broken. - Headers: fix the @author email typo (dev@conductio.nl -> info@conduction.nl) in lib/ and appinfo/routes.php. Parts of #272 that are now obsolete (MainMenu.vue / Dashboard.vue nav and DEFAULT_LAYOUT changes, the duplicate-widget DEFAULT_LAYOUT fix, the "Map"/"Case Map" nav keys) were already resolved by the manifest migration and are intentionally not re-applied. The blanket phpcbf reformat from #272 is left out as out-of-scope; the codebase still has a pre-existing PHPCS baseline tracked separately.
rubenvdlinde
force-pushed
the
fix/dashboard-header-phpcs-i18n
branch
from
30900f4 to
2795c77
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 03:51 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 04:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(re-opened of #420 — accidentally closed by harness force-push; same branch, same content)
Summary
Re-implements the still-relevant parts of #272 cleanly against current
development. The original branch (fix/header-info-email-phpcs) had 40+ merge conflicts withdevelopmentafter the json-manifest migration and couldn't be rebased — this PR supersedes #272.What was re-applied
background/border/border-radius/ fixedpadding) and innermax-heightscrollbars from theDeadlineAlerts,StalledCasesandTaskDueReminderswidgets so they render cleanly inside the manifest dashboard tiles (now a simpleflexcolumn withgap).'Unknown'fallback labels insrc/utils/dashboardHelpers.jsandsrc/utils/doorlooptijdHelpers.jswitht('procest', …); added the missing dashboard translation keys (All cases active,No task reminders,SLA Compliance,View all deadline alerts) tol10n/{en,nl}.{js,json}with human-readable Dutch."Case created with type \","Case type \","Status changed from \","Status changed to \") that actually leftl10n/en.jssyntactically broken ondevelopment; fix: dashboard cleanup + header/PHPCS/i18n improvements #272 removed these too.@authoremail typodev@conductio.nl→info@conduction.nlacrosslib/andappinfo/routes.php(matchesappinfo/info.xml).What was already resolved by the manifest migration (intentionally not re-applied)
src/navigation/MainMenu.vueandsrc/views/Dashboard.vueno longer exist — the nav-nesting fix (Map / Voorstellen) and the duplicate-widgetDEFAULT_LAYOUTconcatenation fix are moot."Map"/"Case Map"/"Cases by status"/"Open cases"/"Stalled Cases"/"Task Due Reminders"/"Deadline Alerts"/"No items found"/"No SLA targets"/"Work Queue"keys from fix: dashboard cleanup + header/PHPCS/i18n improvements #272 are either already present or not referenced by the current source, so they were skipped.phpcbfreformat from fix: dashboard cleanup + header/PHPCS/i18n improvements #272 (~100 files of whitespace churn) is out of scope — procest still carries a pre-existing PHPCS/ESLint/Stylelint baseline tracked separately, and a full reformat would conflict heavily with concurrent work.Verification
vendor/bin/phpcson the touched PHP files: no new errors (the pre-existing 118-error baseline on these files is unchanged before/after).eslinton the touched.js/.vuefiles: clean.l10n/{en,nl}.{js,json}:node --check+python3 -m json.toolall pass (andl10n/en.jsis no longer syntactically broken).src/manifest.jsonuntouched.Follow-ups (deferred)
l10nregeneration is a separate task.phpcbfcan auto-fix ~80 violations in touched-area files) — separate cleanup PR.stylelintconfig references a missingstylelint-config-recommended-scssdep ondevelopment— separate fix.